New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency on tensorflow version 1.4..0 #6

Open

altanai opened this issue Oct 26, 2020 · 0 comments

altanai commented Oct 26, 2020

Dependency on Tensorflow v1.4.0 causes the project to stop since it's hardcoded

if tf.__version__ != '1.4.0':
  raise ImportError('Please upgrade your tensorflow installation to v1.4.0!')

Can be corrected with

from setuptools._distutils.version import StrictVersion 

....

if StrictVersion(tf.__version__) < StrictVersion('1.4.0'):
    raise ImportError('Please upgrade your tensorflow installation to v1.4.* or later!')

I'd be happy to raise a PR for this and a few other small "good to have" changes if that's ok.
PS : awesome project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment