Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted upstream degradation from this app. #185

Closed
eddyb opened this issue Mar 6, 2020 · 7 comments
Closed

Unwanted upstream degradation from this app. #185

eddyb opened this issue Mar 6, 2020 · 7 comments

Comments

@eddyb
Copy link

eddyb commented Mar 6, 2020

I've started to recently observe some anomalies in GitHub's commit->PR references, e.g. rust-lang/rust@33caf0b doesn't point to the rust-lang/rust#67800 PR, which it was a part of.

Instead, it points to https://github.com/nifftytech/rust/pull/85, which is a fork using this pull app to keep up to date.
If #57 had been fixed then this wouldn't really be a problem, because there would be no PRs to confuse GitHub, but as it stands this is undesireable for upstream rust-lang/rust.

Arguably this is partly a @github bug, in that it shouldn't care about forks as much as it seems to right now, but until that changes, using PRs should be considered intrusive (and not just in terms of notifications) and to be avoided at all cost.

I will try to get in contact with someone from @nifftytech and ask them to disable this app and remake the fork, hopefully that would fix GitHub's references.

@wei
Copy link
Owner

wei commented Mar 9, 2020

Do you have a ticket open with GitHub regarding this? PRs can also be created manually with the same behavior you're seeing.

@ghost
Copy link

ghost commented Mar 13, 2020

Hi @wei, @eddyb,

I'm the owner of the Org @nifftytech (an org I made mostly for personal projects), and I've just removed the pull app from each of the apps from the organization.

I can delete the fork, but wanted to make sure that if I did it doesn't lead to problems with the upstream rust-lang/rust repo

@eddyb
Copy link
Author

eddyb commented Mar 13, 2020

@vyasknellutla Hi, I was just about to reply to your emails.
Thanks a lot for getting back to me!

I can delete the fork, but wanted to make sure that if I did it doesn't lead to problems with the upstream rust-lang/rust repo

No, it shouldn't cause problems, and it should fix the problem we're seeing here.

However, I'm submitting a GitHub support request right now, so if you can keep it around until they acknowledge the problem, that would be helpful in demonstrating it.

@ghost
Copy link

ghost commented Mar 13, 2020

@eddyb

However, I'm submitting a GitHub support request right now, so if you can keep it around until they acknowledge the problem, that would be helpful in demonstrating it.

Sure thing!

And sorry for the delayed reply, I hope it didn't cause much damage in the meantime 😅

@eddyb
Copy link
Author

eddyb commented Mar 13, 2020

I hope it didn't cause much damage in the meantime

To be clear, while this is annoying, it just breaks looking up pull requests from commits in the GitHub UI, which I mostly do when using its "blame" views. Since reporting this I haven't needed it again.

@wei
Copy link
Owner

wei commented Apr 21, 2020

Please reply if GitHub provides any updates. In the meantime, feel free to checkout my GitHub Action to support this and many other use cases (without pull request): https://github.com/marketplace/actions/git-sync-action

@wei wei closed this as completed Apr 21, 2020
@eddyb
Copy link
Author

eddyb commented May 26, 2020

Some time since I reported it and before they got back to me, the problem got fixed, and I think the support person replying to me didn't realize what I meant because they saw the fixed version, heh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants