Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcb bolt details #152

Open
crab-pancake opened this issue Jan 28, 2024 · 5 comments
Open

zcb bolt details #152

crab-pancake opened this issue Jan 28, 2024 · 5 comments
Labels
calc Issue affects the core calculator code research

Comments

@crab-pancake
Copy link
Contributor

What went wrong?

https://github.com/weirdgloop/osrs-dps-calc/blob/main/src/lib/CombatCalc.ts#L1241

pearl bolts (on non-fiery target) boost changes from RANGELVL/20 to RANGELVL/18. did not test fiery

diamond bolts: believe multiplier is actually 126.5% not 126%

dragonstone: i think extra damage is actually RANGELVL2/9 instead of RANGELVL22%, tho tests were done a long time ago and idek if these can be distinguished

What did you expect to happen?

No response

What browsers are you seeing the problem on?

Chrome

What device(s) are you seeing the problem on?

Windows

Any other information

No response

@crab-pancake crab-pancake added bug Something isn't working triage labels Jan 28, 2024
@SuperNerdEric
Copy link
Contributor

@LlemonDuck
Copy link
Collaborator

pearl bolts (on non-fiery target) boost changes from RANGELVL/20 to RANGELVL/18.

This makes sense to me but it would be good to test this in-game / get a tweet and then add the information to the wiki.

dragonstone: i think extra damage is actually RANGELVL2/9 instead of RANGELVL22%

These are off by one at a lot of points so it would be easy to test. At level 99, the difference is a max effect damage of 21 using 22 / 100 and 22 using 2 / 9.

I don't have a zcb to test either.

@LlemonDuck LlemonDuck added calc Issue affects the core calculator code research and removed triage labels Jan 28, 2024
@LlemonDuck
Copy link
Collaborator

LlemonDuck commented Jan 28, 2024

Dragonstone bolts are confirmed to be 2/9 using 99 ranged no prayer zcb + dragonstone bolts (e):
image
image

Corresponding calc update in 8877dd5

@LlemonDuck
Copy link
Collaborator

Current hypothesis on pearl bolts is that ZCB subtracts 2 from the denominator. 1/20 => 1/18 for non-fiery, and 1/15 => 1/13 for fiery. https://discord.com/channels/177206626514632704/1098698914498101368/1201068883243716618

I've updated the calc to match in d32277c, but let's keep this open as a research ticket for pearl bolts.

@LlemonDuck LlemonDuck removed the bug Something isn't working label Jan 28, 2024
@jmyaeger
Copy link
Contributor

jmyaeger commented Jan 29, 2024

If the common theme here is that the denominator is being multiplied by 9/10 and truncated—which lines up with the pearl bolt findings here as well as dragonstone bolts and opal bolts—then rubies might actually be dealing currentHP * 2 / 9 damage instead of currentHP * 22 / 100. Have not tested it as I don't have a ZCB.

EDIT: Tested on a beta world, and I hit 99 on Skotizo at full HP (would be 100 if it were 2/9). So it's definitely 22/100 for rubies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calc Issue affects the core calculator code research
Projects
None yet
Development

No branches or pull requests

4 participants