Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Araxyte slayer helm not counting for slayer task #469

Open
Antoine-dh opened this issue Sep 11, 2024 · 1 comment · May be fixed by #472
Open

Araxyte slayer helm not counting for slayer task #469

Antoine-dh opened this issue Sep 11, 2024 · 1 comment · May be fixed by #472
Labels
bug Something isn't working data Sourced data is unavailable/incorrect, e.g. wrong stats, missing fields

Comments

@Antoine-dh
Copy link

What went wrong?

It is the only slayer helm recolor displayed in the list and also doesn't apply task damage boost

What did you expect to happen?

No response

What browsers are you seeing the problem on?

Firefox

What device(s) are you seeing the problem on?

Windows

Any other information

No response
@Antoine-dh Antoine-dh added bug Something isn't working triage labels Sep 11, 2024
@Antoine-dh
Copy link
Author

Do not have time to PR but I believe is fixed by adding it to this regex

osrs-dps-calc/scripts/generateEquipmentAliases.py

Line 119 in 9ff475c

slayer_helm_match = re.match(r"^(?:Black|Green|Red|Purple|Turquoise|Hydra|Twisted|Tztok|Vampyric|Tzkal) slayer helmet( \(i\))?$", item['name'])

@LlemonDuck LlemonDuck linked a pull request Sep 16, 2024 that will close this issue
Open
@LlemonDuck LlemonDuck added data Sourced data is unavailable/incorrect, e.g. wrong stats, missing fields and removed triage labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working data Sourced data is unavailable/incorrect, e.g. wrong stats, missing fields
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

aliases: include araxyte slayer helm weirdgloop/osrs-dps-calc
2 participants
@LlemonDuck @Antoine-dh