Cache key not updating on change

[sallomendo]

Bug Report

Describe the Bug

fetchPredictions callback is not updating when cache or cacheKey changes.

How to Reproduce

When the cache key is stateful, the window storage key doesn't change.

const [countryCode, setCountryCode] = useState("US")

const autocomplete = usePlacesAutocomplete({
    cacheKey: countryCode
});

Expected Behavior

The cache and cache key should change when you pass a different value.

Your Environment

• Device: MacBook Pro
• OS: macOS
• Browser: Chrome
• Version: 1.11.0

Additional Information

I think we need to add cache and cacheKey as a dependency to the useCallback hook here https://github.com/wellyshen/use-places-autocomplete/blob/master/src/usePlacesAutocomplete.ts#L155

[wellyshen]

@sallomendo Ask a DX question. Should we need to remove the previously cached data when the key is updated?

[sallomendo]

@wellyshen I don’t think so, we can use the clearCache function inside a useEffect hook, I think we should leave that to the dev.

[wellyshen]

@sallomendo Sorry quite busy recently, would you mind to give me a PR for this issue?

[wellyshen]

@sallomendo This issue has been fixed in the latest version.

[sallomendo]

@wellyshen thanks for working on this, I will close the pr I created for this.

[wellyshen]

@sallomendo Sorry I didn't note that, thank you!