Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Dependance Error #63

Closed
romain325 opened this issue Sep 11, 2020 · 4 comments
Closed

Bug: Dependance Error #63

romain325 opened this issue Sep 11, 2020 · 4 comments

Comments

@romain325
Copy link

NPM Error Message:

Failed to compile.

./node_modules/@welovedevs/ui/popper_card/popper_card.js
Module not found: Can't resolve '../assets/icons/speech_bubble_arrow.svg' in '/home/romain/prog/website/react-ui/node_modules/@welovedevs/ui/popper_card'

Apparently it is a quiet simple correction to do, I just haven't looked where the code of "@welovedevs/react-ultimate-resume/" is and how I can modify it

Tested on: Default project (git clone) and personal project(npm i)

I might pull later, any help on where are the files is always pleasant!
Thanks a lot

@romain325
Copy link
Author

Changed package.json and put "@welovdevs/ui" to the latest (1.1.0) and fixed this issue
However another issue appeared;

Warning: useLayoutEffect received a final argument that is not an array (instead, received `object`). When specified, the final argument must be an array.
    in ProfileCardComponent (at soundtrack_card.jsx:40)
    in SoundtrackCardComponent (created by CardsComponent)

Seems like a problem with react-spring useTransition()

@clementdevos
Copy link
Contributor

Hi @romain325

As explained here #48 (comment), we're waiting on react-spring to be in a stable version (ie. v9.0.0) to update it as it's not yet stable, which is kind of a pain in the ...

We're updating our ui lib to typescript, leading to your issue with the missing .svg file.

Can you please downgrade the @welovedevs/ui to the v1.0.5-beta.11 version which is not using typescript yet?
Also make sure to use node v12 for now...
I'll fix everything up (react-spring and our design system) when react-spring is stable.

https://github.com/react-spring/react-spring/milestone/1

@romain325
Copy link
Author

No problem thanks a lot for the support !
If any help is needed, it will be a pleasure :)
(btw in the ui I think there is a little typo:
ancient version was "@welovdevs/ui/styles/pallettes.js" and the new is "styles/pallette.ts")

@clementdevos
Copy link
Contributor

closing this in favor of #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants