Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False negative comprehension structure for WPS361 #2075

Closed
sobolevn opened this issue Jun 23, 2021 · 1 comment
Closed

False negative comprehension structure for WPS361 #2075

sobolevn opened this issue Jun 23, 2021 · 1 comment
Assignees
@sobolevn
Labels
bug Something isn't working
Milestone
Version 0.16

Comments

@sobolevn
Copy link
Member

sobolevn commented Jun 23, 2021 •
edited
Loading

What's wrong

This code does not raise a WPS361 violation:

rules = [
    rule for rule in
    config.get_option(self._rules_opt_name).items()
]

How it should be

It should

Flake8 version and plugins

[email protected]
@sobolevn sobolevn added the bug Something isn't working label Jun 23, 2021
@sobolevn sobolevn self-assigned this Jun 23, 2021
@sobolevn sobolevn added this to the Version 0.15.x milestone Jun 23, 2021
@sobolevn sobolevn modified the milestones: Version 0.15.x, Version 0.16 Jun 23, 2021
@sobolevn
Copy link
Member Author

Ok, it is better to release this under 0.16.0, because it may produce new violations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 0.16
Development

No branches or pull requests
1 participant
@sobolevn