From 0c6d0fa660da009733d7f0336d26544fa575a588 Mon Sep 17 00:00:00 2001
From: Wendell Piez <wendell.piez@nist.gov>
Date: Thu, 13 Oct 2022 16:56:26 -0400
Subject: [PATCH] Start at modeling out tests for JSON Schema provision of
 enumerated value constraints (where possible) #240

---
 .../json-schema-gen/json-schema-gen.xspec     |  23 +++
 ...lue-testing-mini-jsonschema-CORRECTED.json | 116 +++++++++++
 ...ue-testing-mini-jsonschema-CORRECTED2.json | 112 +++++++++++
 .../json-value-testing-mini-jsonschema.json   | 126 ++++++++++++
 .../json-value-testing-mini-metaschema.xml    | 186 ++++++++++++++++++
 .../json-schema-gen/testing01-valid.json      |  24 +++
 .../json-schema-gen/testing02-valid.json      |   8 +
 .../json-schema-gen/testing03-valid.json      |  24 +++
 .../json-schema-gen/testing04-INVALID.json    |   8 +
 .../json-schema-gen/testing05-valid.json      |  24 +++
 .../json-schema-gen/testing06-INVALID.json    |  12 ++
 11 files changed, 663 insertions(+)
 create mode 100644 test-suite/metaschema-xspec/json-schema-gen/json-schema-gen.xspec
 create mode 100644 test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-jsonschema-CORRECTED.json
 create mode 100644 test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-jsonschema-CORRECTED2.json
 create mode 100644 test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-jsonschema.json
 create mode 100644 test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-metaschema.xml
 create mode 100644 test-suite/metaschema-xspec/json-schema-gen/testing01-valid.json
 create mode 100644 test-suite/metaschema-xspec/json-schema-gen/testing02-valid.json
 create mode 100644 test-suite/metaschema-xspec/json-schema-gen/testing03-valid.json
 create mode 100644 test-suite/metaschema-xspec/json-schema-gen/testing04-INVALID.json
 create mode 100644 test-suite/metaschema-xspec/json-schema-gen/testing05-valid.json
 create mode 100644 test-suite/metaschema-xspec/json-schema-gen/testing06-INVALID.json

diff --git a/test-suite/metaschema-xspec/json-schema-gen/json-schema-gen.xspec b/test-suite/metaschema-xspec/json-schema-gen/json-schema-gen.xspec
new file mode 100644
index 000000000..3a61c2e9f
--- /dev/null
+++ b/test-suite/metaschema-xspec/json-schema-gen/json-schema-gen.xspec
@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- autogenerated 2021-12-14T16:02:57.305-05:00 following model in example-set.xspec-->
+<x:description xmlns:x="http://www.jenitennison.com/xslt/xspec"
+   xmlns="http://csrc.nist.gov/ns/oscal/metaschema/1.0"
+               stylesheet=""
+               run-as="external"
+               xmlns:ov="http://csrc.nist.gov/ns/oscal/test/variable">
+
+   <!-- <x:helper stylesheet=" ... composer ... "/> -->
+   <!-- old tests are out of whack need update to current functionality /spec  -->
+   <!-- but the XSpec provides a functional model -->
+   
+   <!--<x:scenario label="Base test">
+      <!-\- Alternative model for test scrubbing both the result and the expected
+           result for comparison -\->
+      <x:context href="profile-resolution-examples/base-test_profile.xml"/>
+      <x:variable name="ov:expected-output"
+         href="profile-resolution-examples/output-expected/base-test_profile_RESOLVED.xml"/>
+      <x:expect label="Base test - fully resolved"
+         test="opr:scrub($x:result)" select="opr:scrub($ov:expected-output)"/>
+   </x:scenario>-->
+   
+</x:description>
diff --git a/test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-jsonschema-CORRECTED.json b/test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-jsonschema-CORRECTED.json
new file mode 100644
index 000000000..1b2175745
--- /dev/null
+++ b/test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-jsonschema-CORRECTED.json
@@ -0,0 +1,116 @@
+  { "$schema" : "http://json-schema.org/draft-07/schema#",
+    "$id" : "http://csrc.nist.gov/ns/oscal/0.1/oscal-value-testing-mini-schema.json",
+    "$comment" : "JSON value testing mini metaschema: JSON Schema",
+    "type" : "object",
+    "definitions" : 
+    { "oscal-value-testing-mini-oscal-value-testing-mini:root" : 
+      { "title" : "Root",
+        "description" : "Root root root.",
+        "$id" : "#assembly_oscal-value-testing-mini_root",
+        "type" : "object",
+        "properties" : 
+        { "unconstrained" : 
+          { "$ref" : "#field_oscal-value-testing-mini_unconstrained" },
+          "constrained-open" : 
+          { "$ref" : "#field_oscal-value-testing-mini_constrained-open" },
+          "constrained-closed" : 
+          { "$ref" : "#field_oscal-value-testing-mini_constrained-closed" },
+          "constrained-narrow" : 
+          { "$ref" : "#field_oscal-value-testing-mini_constrained-narrow" },
+          "constrained-sortof" : 
+          { "$ref" : "#field_oscal-value-testing-mini_constrained-sortof" } },
+        "additionalProperties" : false },
+      "oscal-value-testing-mini-oscal-value-testing-mini:unconstrained" : 
+      { "title" : "Unconstrained",
+        "description" : "A field whose value is constrained only by its nominal datatype, 'token'.",
+        "$id" : "#field_oscal-value-testing-mini_unconstrained",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          { "type" : "string" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false },
+      "oscal-value-testing-mini-oscal-value-testing-mini:constrained-open" : 
+      { "title" : "Constrained open",
+        "description" : "Because allow-other is 'yes' no enumeration can be given in the JSON Schema.",
+        "$id" : "#field_oscal-value-testing-mini_constrained-open",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          { "type" : "string" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false },
+      "oscal-value-testing-mini-oscal-value-testing-mini:constrained-closed" : 
+      { "title" : "Constrained closed",
+        "description" : "Because allow-other is 'no' an enumeration can be given in the JSON Schema.",
+        "$id" : "#field_oscal-value-testing-mini_constrained-closed",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          { "type" : "string",
+            "enum" : 
+                [ "one",
+                  "two",
+                  "three",
+                  "four" ] } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false
+         },
+      "oscal-value-testing-mini-oscal-value-testing-mini:constrained-narrow" : 
+      { "title" : "Constrained narrow",
+        "description" : "Although allow-other is 'no' an enumeration can't be given in the JSON Schema since it targets a qualified set (only a subset) of the elements in scope.",
+        "$id" : "#field_oscal-value-testing-mini_constrained-narrow",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          { "type" : "string" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false },
+      "oscal-value-testing-mini-oscal-value-testing-mini:constrained-sortof" : 
+      { "title" : "Constrained, sort of",
+        "description" : "Although allow-other is 'no' an enumeration can't be given in the JSON Schema since it targets a qualified set (only a subset) of the elements in scope.",
+        "$id" : "#field_oscal-value-testing-mini_constrained-sortof",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          { "type" : "string" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false },
+      "StringDatatype" : 
+      { "type" : "string",
+        "pattern" : "^\\S(.*\\S)?$" },
+      "TokenDatatype" : 
+      { "type" : "string",
+        "pattern" : "^(\\p{L}|_)(\\p{L}|\\p{N}|[.\\-_])*$" } },
+    "properties" : 
+    { "root" : 
+      { "$ref" : "#assembly_oscal-value-testing-mini_root" } },
+    "required" : 
+    [ "root" ],
+    "additionalProperties" : false,
+    "maxProperties" : 1 }
\ No newline at end of file
diff --git a/test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-jsonschema-CORRECTED2.json b/test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-jsonschema-CORRECTED2.json
new file mode 100644
index 000000000..03ec73487
--- /dev/null
+++ b/test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-jsonschema-CORRECTED2.json
@@ -0,0 +1,112 @@
+  { "$schema" : "http://json-schema.org/draft-07/schema#",
+    "$id" : "http://csrc.nist.gov/ns/oscal/0.1/oscal-value-testing-mini-schema.json",
+    "$comment" : "JSON value testing mini metaschema: JSON Schema",
+    "type" : "object",
+    "definitions" : 
+    { "oscal-value-testing-mini-oscal-value-testing-mini:root" : 
+      { "title" : "Root",
+        "description" : "Root root root.",
+        "$id" : "#assembly_oscal-value-testing-mini_root",
+        "type" : "object",
+        "properties" : 
+        { "unconstrained" : 
+          { "$ref" : "#field_oscal-value-testing-mini_unconstrained" },
+          "constrained-open" : 
+          { "$ref" : "#field_oscal-value-testing-mini_constrained-open" },
+          "constrained-closed" : 
+          { "$ref" : "#field_oscal-value-testing-mini_constrained-closed" },
+          "constrained-narrow" : 
+          { "$ref" : "#field_oscal-value-testing-mini_constrained-narrow" },
+          "constrained-sortof" : 
+          { "$ref" : "#field_oscal-value-testing-mini_constrained-sortof" } },
+        "additionalProperties" : false },
+      "oscal-value-testing-mini-oscal-value-testing-mini:unconstrained" : 
+      { "title" : "Unconstrained",
+        "description" : "A field whose value is constrained only by its nominal datatype, 'token'.",
+        "$id" : "#field_oscal-value-testing-mini_unconstrained",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          { "$ref" : "#/definitions/TokenDatatype"
+          } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false },
+      "oscal-value-testing-mini-oscal-value-testing-mini:constrained-open" : 
+      { "title" : "Constrained open",
+        "description" : "Because allow-other is 'yes' no enumeration can be given in the JSON Schema.",
+        "$id" : "#field_oscal-value-testing-mini_constrained-open",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          {  "$ref" : "#/definitions/TokenDatatype" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false },
+      "oscal-value-testing-mini-oscal-value-testing-mini:constrained-closed" : 
+      { "title" : "Constrained closed",
+        "description" : "Because allow-other is 'no' an enumeration can be given in the JSON Schema.",
+        "$id" : "#field_oscal-value-testing-mini_constrained-closed",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          {  "$ref" : "#/definitions/TokenDatatype" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false
+         },
+      "oscal-value-testing-mini-oscal-value-testing-mini:constrained-narrow" : 
+      { "title" : "Constrained narrow",
+        "description" : "Although allow-other is 'no' an enumeration can't be given in the JSON Schema since it targets a qualified set (only a subset) of the elements in scope.",
+        "$id" : "#field_oscal-value-testing-mini_constrained-narrow",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          {  "$ref" : "#/definitions/TokenDatatype" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false },
+      "oscal-value-testing-mini-oscal-value-testing-mini:constrained-sortof" : 
+      { "title" : "Constrained, sort of",
+        "description" : "Although allow-other is 'no' an enumeration can't be given in the JSON Schema since it targets a qualified set (only a subset) of the elements in scope.",
+        "$id" : "#field_oscal-value-testing-mini_constrained-sortof",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          { "type" : "string" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false },
+      "StringDatatype" : 
+      { "type" : "string",
+        "pattern" : "^\\S(.*\\S)?$" },
+      "TokenDatatype" : 
+      { "type" : "string",
+        "pattern" : "^(\\p{L}|_)(\\p{L}|\\p{N}|[.\\-_])*$" } },
+    "properties" : 
+    { "root" : 
+      { "$ref" : "#assembly_oscal-value-testing-mini_root" } },
+    "required" : 
+    [ "root" ],
+    "additionalProperties" : false,
+    "maxProperties" : 1 }
\ No newline at end of file
diff --git a/test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-jsonschema.json b/test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-jsonschema.json
new file mode 100644
index 000000000..424d2cfa5
--- /dev/null
+++ b/test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-jsonschema.json
@@ -0,0 +1,126 @@
+
+  { "$schema" : "http://json-schema.org/draft-07/schema#",
+    "$id" : "http://csrc.nist.gov/ns/oscal/0.1/oscal-value-testing-mini-schema.json",
+    "$comment" : "JSON value testing mini metaschema: JSON Schema",
+    "type" : "object",
+    "definitions" : 
+    { "oscal-value-testing-mini-oscal-value-testing-mini:root" : 
+      { "title" : "Root",
+        "description" : "Root root root.",
+        "$id" : "#assembly_oscal-value-testing-mini_root",
+        "type" : "object",
+        "properties" : 
+        { "unconstrained" : 
+          { "$ref" : "#field_oscal-value-testing-mini_unconstrained" },
+          "constrained-open" : 
+          { "$ref" : "#field_oscal-value-testing-mini_constrained-open" },
+          "constrained-closed" : 
+          { "$ref" : "#field_oscal-value-testing-mini_constrained-closed" },
+          "constrained-narrow" : 
+          { "$ref" : "#field_oscal-value-testing-mini_constrained-narrow" },
+          "constrained-sortof" : 
+          { "$ref" : "#field_oscal-value-testing-mini_constrained-sortof" } },
+        "additionalProperties" : false },
+      "oscal-value-testing-mini-oscal-value-testing-mini:unconstrained" : 
+      { "title" : "Unconstrained",
+        "description" : "A field whose value is constrained only by its nominal datatype, 'token'.",
+        "$id" : "#field_oscal-value-testing-mini_unconstrained",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          { "type" : "string" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false },
+      "oscal-value-testing-mini-oscal-value-testing-mini:constrained-open" : 
+      { "title" : "Constrained open",
+        "description" : "Because allow-other is 'yes' no enumeration can be given in the JSON Schema.",
+        "$id" : "#field_oscal-value-testing-mini_constrained-open",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          { "type" : "string" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false },
+      "oscal-value-testing-mini-oscal-value-testing-mini:constrained-closed" : 
+      { "title" : "Constrained closed",
+        "description" : "Because allow-other is 'no' an enumeration can be given in the JSON Schema.",
+        "$id" : "#field_oscal-value-testing-mini_constrained-closed",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          { "type" : "string" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false,
+        "enum" : 
+        [ "one",
+          "two",
+          "three",
+          "four" ] },
+      "oscal-value-testing-mini-oscal-value-testing-mini:constrained-narrow" : 
+      { "title" : "Constrained narrow",
+        "description" : "Although allow-other is 'no' an enumeration can't be given in the JSON Schema since it targets a qualified set (only a subset) of the elements in scope.",
+        "$id" : "#field_oscal-value-testing-mini_constrained-narrow",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          { "type" : "string" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false,
+        "enum" : 
+        [ "one",
+          "two",
+          "three",
+          "four" ] },
+      "oscal-value-testing-mini-oscal-value-testing-mini:constrained-sortof" : 
+      { "title" : "Constrained, sort of",
+        "description" : "Although allow-other is 'no' an enumeration can't be given in the JSON Schema since it targets a qualified set (only a subset) of the elements in scope.",
+        "$id" : "#field_oscal-value-testing-mini_constrained-sortof",
+        "type" : "object",
+        "properties" : 
+        { "some" : 
+          { "title" : "Some Flag",
+            "description" : "Some flag some flag some flag.",
+            "$ref" : "#/definitions/StringDatatype" },
+          "token-value" : 
+          { "type" : "string" } },
+        "required" : 
+        [ "token-value" ],
+        "additionalProperties" : false,
+        "enum" : 
+        [ "one",
+          "two",
+          "three",
+          "four" ] },
+      "StringDatatype" : 
+      { "type" : "string",
+        "pattern" : "^\\S(.*\\S)?$" },
+      "TokenDatatype" : 
+      { "type" : "string",
+        "pattern" : "^(\\p{L}|_)(\\p{L}|\\p{N}|[.\\-_])*$" } },
+    "properties" : 
+    { "root" : 
+      { "$ref" : "#assembly_oscal-value-testing-mini_root" } },
+    "required" : 
+    [ "root" ],
+    "additionalProperties" : false,
+    "maxProperties" : 1 }
\ No newline at end of file
diff --git a/test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-metaschema.xml b/test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-metaschema.xml
new file mode 100644
index 000000000..420d11183
--- /dev/null
+++ b/test-suite/metaschema-xspec/json-schema-gen/json-value-testing-mini-metaschema.xml
@@ -0,0 +1,186 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<?xml-stylesheet type="text/css" href="metaschema-author.css"?>
+<METASCHEMA xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://csrc.nist.gov/ns/oscal/metaschema/1.0 ${pdu}/build/metaschema/schema/xml/metaschema.xsd"
+ xmlns="http://csrc.nist.gov/ns/oscal/metaschema/1.0" abstract="no">
+    <schema-name>JSON value testing mini metaschema</schema-name>
+    <schema-version>0.1</schema-version>
+    <short-name>oscal-value-testing-mini</short-name>
+    <namespace>http://csrc.nist.gov/ns/oscal/1.0</namespace>
+    <json-base-uri>http://csrc.nist.gov/ns/oscal</json-base-uri>
+    
+    
+<!--
+        XML looks like this:
+        
+        valid:
+        <root>
+        </root>
+             
+
+        not valid:
+        <root>
+             <value-required-since-token/>
+             <always-enumerated>ae5</always-enumerated>
+             <always-enumerated/>
+        </root>
+             
+    
+    -->
+    <define-assembly name="root">
+        <formal-name>Root</formal-name>
+        <description>Root root root.</description>
+        <root-name>root</root-name>
+        <model>
+            <field ref="unconstrained"/>
+            <field ref="constrained-open"/>
+            <field ref="constrained-closed"/>
+            <field ref="constrained-narrow"/>
+            <field ref="constrained-sortof"/>
+        </model>
+    </define-assembly>
+    
+<!-- for field someties-requiring the enumeration should appear in the JSON Schema
+     only if the datatype requires at least one character (is not 'nullable') -->
+    <!--<define-field 
+        as-type="token"
+        name="value-required-since-token">
+        <formal-name>Field with required value property</formal-name>
+        <description>The value key here must be required iff the datatype requires a character;
+            permitting an empty string, the `nar-value` field should be optional (because 'nullable').</description>
+        <json-value-key>rst-value</json-value-key>
+        <define-flag name="some">
+            <formal-name>Some Flag</formal-name>
+            <description>Some flag some flag some flag.</description>
+        </define-flag>
+    </define-field>-->
+    
+    <!--<define-field 
+        as-type="token"
+        name="value-not-required-since-string">
+        <formal-name>Field with optional value property</formal-name>
+        <description>The value key here must be optional since a string value can be empty (""),
+            providing for a syntax optimization in JSON representations (the value property can be dropped).</description>
+        <json-value-key>nrs-value</json-value-key>
+        <define-flag name="some">
+            <formal-name>Some Flag</formal-name>
+            <description>Some flag some flag some flag.</description>
+        </define-flag>
+    </define-field>-->
+    <!--
+    fields to define
+    
+    unconstrained
+        no values enumerated
+    constrained-open
+      - allow-others='yes', values enumerated
+    constrained-closed
+      - allow-others='no', values enumerated
+    constrained-default
+      - same as constrained-closed
+    constrained-narrow
+      - allow-others='no', values enumerated on *some* cases
+    constrained-sortof
+      - allow-others='yes', values enumerated on *some* cases
+    
+    -->
+    
+    <define-field 
+        as-type="token"
+        name="unconstrained">
+        <formal-name>Unconstrained</formal-name>
+        <description>A field whose value is constrained only by its nominal datatype, 'token'.</description>
+        <json-value-key>token-value</json-value-key>
+        <define-flag name="some">
+            <formal-name>Some Flag</formal-name>
+            <description>Some flag some flag some flag.</description>
+        </define-flag>
+    </define-field>
+    
+    <!-- field constrained-open has allowed values, but allow-other="yes" so they are not exclusive -->
+    <define-field 
+        as-type="token"
+        name="constrained-open">
+        <formal-name>Constrained open</formal-name>
+        <description>Because allow-other is 'yes' no enumeration can be given in the JSON Schema.</description>
+        <json-value-key>token-value</json-value-key>
+        <define-flag name="some">
+            <formal-name>Some Flag</formal-name>
+            <description>Some flag some flag some flag.</description>
+        </define-flag>
+        <!--<constraint>
+            <allowed-values target="." allow-other="yes">
+                <enum value="one"/>
+                <enum value="two"/>
+                <enum value="three"/>
+                <enum value="four"/>
+            </allowed-values>
+        </constraint>-->
+    </define-field>
+    
+    <!-- field constrained-closed has allowed values, exclusively - the 'normal' case -->
+    <define-field 
+        as-type="token"
+        name="constrained-closed">
+        <formal-name>Constrained closed</formal-name>
+        <description>Because allow-other is 'no' an enumeration can be given in the JSON Schema.</description>
+        <json-value-key>token-value</json-value-key>
+        <define-flag name="some">
+            <formal-name>Some Flag</formal-name>
+            <description>Some flag some flag some flag.</description>
+        </define-flag>
+        <constraint>
+            <allowed-values target="." allow-other="no">
+                <enum value="one"/>
+                <enum value="two"/>
+                <enum value="three"/>
+                <enum value="four"/>
+            </allowed-values>
+        </constraint>
+    </define-field>
+    
+    <!-- field constrained-narrow has allowed values, exclusively, but only on a subset of scoped elements -->
+    <define-field 
+        as-type="token"
+        name="constrained-narrow">
+        <formal-name>Constrained narrow</formal-name>
+        <description>Although allow-other is 'no' an enumeration can't be given in the JSON Schema since it targets a qualified set (only a subset) of the elements in scope.</description>
+        <json-value-key>token-value</json-value-key>
+        <define-flag name="some">
+            <formal-name>Some Flag</formal-name>
+            <description>Some flag some flag some flag.</description>
+        </define-flag>
+        <constraint>
+            <allowed-values target=".[not(false())]" allow-other="no">
+                <enum value="one"/>
+                <enum value="two"/>
+                <enum value="three"/>
+                <enum value="four"/>
+            </allowed-values>
+        </constraint>
+    </define-field>
+    
+    <!-- field constrained-sortof is like constrain-narrow, but allow-other is 'yes' -->
+    <define-field 
+        as-type="token"
+        name="constrained-sortof">
+        <formal-name>Constrained, sort of</formal-name>
+        <description>Although allow-other is 'no' an enumeration can't be given in the JSON Schema since it targets a qualified set (only a subset) of the elements in scope.</description>
+        <json-value-key>token-value</json-value-key>
+        <define-flag name="some">
+            <formal-name>Some Flag</formal-name>
+            <description>Some flag some flag some flag.</description>
+        </define-flag>
+        <constraint>
+            <allowed-values target=".[not(false())]" allow-other="no">
+                <enum value="one"/>
+                <enum value="two"/>
+                <enum value="three"/>
+                <enum value="four"/>
+            </allowed-values>
+        </constraint>
+    </define-field>
+    
+    
+    </METASCHEMA>
+
diff --git a/test-suite/metaschema-xspec/json-schema-gen/testing01-valid.json b/test-suite/metaschema-xspec/json-schema-gen/testing01-valid.json
new file mode 100644
index 000000000..764870fa2
--- /dev/null
+++ b/test-suite/metaschema-xspec/json-schema-gen/testing01-valid.json
@@ -0,0 +1,24 @@
+{
+    "root": {
+        "unconstrained": {
+            "some": "a",
+            "token-value": "any"
+        },
+        "constrained-open": {
+            "some": "b",
+            "token-value": "one"
+        },
+        "constrained-closed": {
+            "some": "c",
+            "token-value": "two"
+        },
+        "constrained-narrow": {
+            "some": "d",
+            "token-value": "three"
+        },
+        "constrained-sortof": {
+            "some": "e",
+            "token-value": "four"
+        }
+    }
+}
\ No newline at end of file
diff --git a/test-suite/metaschema-xspec/json-schema-gen/testing02-valid.json b/test-suite/metaschema-xspec/json-schema-gen/testing02-valid.json
new file mode 100644
index 000000000..188047ffc
--- /dev/null
+++ b/test-suite/metaschema-xspec/json-schema-gen/testing02-valid.json
@@ -0,0 +1,8 @@
+{
+    "root": {
+        "unconstrained": {
+            "some": "a",
+            "token-value": "anything"
+        }
+    }
+}
\ No newline at end of file
diff --git a/test-suite/metaschema-xspec/json-schema-gen/testing03-valid.json b/test-suite/metaschema-xspec/json-schema-gen/testing03-valid.json
new file mode 100644
index 000000000..a69802130
--- /dev/null
+++ b/test-suite/metaschema-xspec/json-schema-gen/testing03-valid.json
@@ -0,0 +1,24 @@
+{
+    "root": {
+        "unconstrained": {
+            "some": "a",
+            "token-value": "any"
+        },
+        "constrained-open": {
+            "some": "b",
+            "token-value": "one"
+        },
+        "constrained-closed": {
+            "some": "c",
+            "token-value": "three"
+        },
+        "constrained-narrow": {
+            "some": "d",
+            "token-value": "three"
+        },
+        "constrained-sortof": {
+            "some": "e",
+            "token-value": "four"
+        }
+    }
+}
\ No newline at end of file
diff --git a/test-suite/metaschema-xspec/json-schema-gen/testing04-INVALID.json b/test-suite/metaschema-xspec/json-schema-gen/testing04-INVALID.json
new file mode 100644
index 000000000..c19e4829e
--- /dev/null
+++ b/test-suite/metaschema-xspec/json-schema-gen/testing04-INVALID.json
@@ -0,0 +1,8 @@
+{
+    "root": {
+        "constrained-closed": {
+            "some": "c",
+            "token-value": "FIVE"
+        }
+    }
+}
\ No newline at end of file
diff --git a/test-suite/metaschema-xspec/json-schema-gen/testing05-valid.json b/test-suite/metaschema-xspec/json-schema-gen/testing05-valid.json
new file mode 100644
index 000000000..5e0fc39f5
--- /dev/null
+++ b/test-suite/metaschema-xspec/json-schema-gen/testing05-valid.json
@@ -0,0 +1,24 @@
+{
+    "root": {
+        "unconstrained": {
+            "some": "a",
+            "token-value": "any"
+        },
+        "constrained-open": {
+            "some": "b",
+            "token-value": "old"
+        },
+        "constrained-closed": {
+            "some": "c",
+            "token-value": "three"
+        },
+        "constrained-narrow": {
+            "some": "d",
+            "token-value": "value"
+        },
+        "constrained-sortof": {
+            "some": "e",
+            "token-value": "works"
+        }
+    }
+}
\ No newline at end of file
diff --git a/test-suite/metaschema-xspec/json-schema-gen/testing06-INVALID.json b/test-suite/metaschema-xspec/json-schema-gen/testing06-INVALID.json
new file mode 100644
index 000000000..b43f7a3f5
--- /dev/null
+++ b/test-suite/metaschema-xspec/json-schema-gen/testing06-INVALID.json
@@ -0,0 +1,12 @@
+{
+    "root": {
+        "unconstrained": {
+            "some": "a",
+            "token-value": "any OLD"
+        },
+        "constrained-open": {
+            "some": "b",
+            "token-value": "STRING value"
+        }
+    }
+}
\ No newline at end of file