Possible issue with bundled pHash

[twoofy]

Bundled pHash does not seem to be the patched version mentioned:

bash$ pwd
/home/gsaylor/repos/siq_scan/siq_scan/phashion-1.0.6/ext/phashion_ext

bash$ ls -l /home/gsaylor/pHash-0.9.6.tar.gz
-rw-r--r--@ 1 gsaylor staff 1315965 Jan 22 10:57
/home/gsaylor/pHash-0.9.6.tar.gz

bash$ ls -l pHash-0.9.6.tar.gz
-rw-r--r-- 1 gsaylor staff 1899873 Jan 22 10:55 pHash-0.9.6.tar.gz

bash$ tar -zxf /Users/gsaylor/Downloads/pHash-0.9.6.tar.gz

bash$ mv pHash-0.9.6 pHash-0.9.6.orig

bash$ tar -zxf pHash-0.9.6.tar.gz

bash$ diff -r pHash-0.9.6/ pHash-0.9.6.orig/
Only in pHash-0.9.6/: CImg-1.4.7
Only in pHash-0.9.6/: CImg.h

bash$ diff pHash-0.9.6/src/pHash.cpp pHash-0.9.6.orig/src/pHash.cpp

[westonplatter]

@twoofy hey, sorry it took me so long to reply. I think I rigged my github notifications preferences incorrectly. :)

Not sure if this is it, but from your pwd, it looks like you're on phashion-1.0.6. Changes to the bundled pHash version were stablized at phashion-1.0.8.

Just to double check, I opened the bundled pHash, and the westonplatter/phash@ff255d2 changes were present.

Please let me know if you think I missed something. I'd hate to have this promised functionality missing.

[twoofy]

Thats probably it.

I got (and seem to still get?) 1.0.6 when I do "gem install phashion". I'm pretty new to Ruby, so there might be something I'm doing wrong?

bash$ gem fetch phashion
Fetching: phashion-1.0.6.gem (100%)
Downloaded phashion-1.0.6

bash$ gem fetch phashion --version '>= 1.0.8'
ERROR: Could not find a valid gem 'phashion' (>= 1.0.8) in any repository

[westonplatter]

@twoofy that's my bad. :(. I have not pushed the newest version to rubygems. if you're using bundler, explicitly tell bundler to use this project's git endpoin. This will download and compile the phashion from source. Example bundler file,

source "https://rubygems.org"

gem "phashion", :git => "[email protected]:westonplatter/phashion.git"

I'll you're trying to use phashion from the command line only, I'd try using, https://github.com/rdp/specific_install.

@mperham - how do you want to handle pushing new gem versions to rubygems?

[twoofy]

Hello,

I am curious of the progress on this. We use bundle and are including phashion via a add_dependency and there does not seem to be a way to add the :git line to that.

So, what this means, is that everyplace the gemspec is included we need to add a line to that apps Gemfile - a real pain.

Thanks as always!

• Greg

[westonplatter]

@mperham - could we hash together a RubyGems distribution push in the next week?

[mperham]

Do you not have push access?

On Mar 9, 2014, at 16:50, Weston Platter [email protected] wrote:

@mperham - could we hash together a RubyGems distribution push in the next week?

—
Reply to this email directly or view it on GitHub.

[westonplatter]

@mperham no.

gem push phashion-1.0.8.gem
Pushing gem to https://rubygems.org...
You do not have permission to push to this gem.

I think this will do the trick. http://help.rubygems.org/discussions/problems/72-how-can-i-let-multiple-people-push-out-a-new-version-of-a-gem. email = westonplatter [at] gmail [dot] com. rubygems profile = https://rubygems.org/profiles/westonplatter

[mperham]

Fixed.

[westonplatter]

@mperham thanks. I'll push a version tonight.

[westonplatter]

@twoofy I published phashion version 1.1.0 (http://rubygems.org/gems/phashion/versions/1.1.0) has updated pHash lib mentioned in the readme, https://github.com/westonplatter/phashion#gem-uses-customized-phash-096.

I'll close the issue since we pushed a new version. Please re-open if issue persists.