Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with OSX 10.15 #966

Open
booherbg opened this issue Nov 21, 2023 · 13 comments
Open

Compatibility with OSX 10.15 #966

booherbg opened this issue Nov 21, 2023 · 13 comments

Comments

@booherbg
Copy link

booherbg commented Nov 21, 2023

Hi,

I am running Catalina, which I understand is out of support (This 2012 MBP runs Serato flawlessly and is my daily driver, 16GB of RAM and 8 cores and I hate throwing out working hardware, but issues like this certainly can get in the way). I also understand that the project maintainers are under no obligation to assist me so thank you for at least entertaining me by reading this post :)

I can build the project just fine with python 3.10, but can't run due to a compatibility issue with Qt.

I'm curious if anyone can point me to a version that may have a dependency on Qt prior to 6.5 (which is where 10.15 support was dropped)? Alternatively, any other ideas are welcome.

$ NowPlaying
Sorry, "Python" cannot be run on this version of macOS. Qt requires macOS 11.0.0 or later, you have macOS 10.15.7.

I can't find the Qt dependencies in requirements*.txt otherwise I'd try dropping back to an earlier version and seeing where that gets me. This is on the latest 4.1.0-rc3 branch.

@aw-was-here
Copy link
Collaborator

Hello!

The Qt dependencies basically come in from PySide6 which you can find here. You might be able to drop that dependency far down enough that Catalina is supported but I'm not sure at what point things will break.

@booherbg
Copy link
Author

booherbg commented Nov 21, 2023

Hello!

The Qt dependencies basically come in from PySide6 which you can find here. You might be able to drop that dependency far down enough that Catalina is supported but I'm not sure at what point things will break.

Thank you! I'll play around with it and see where it gets me. Great project by the way!

I believe that the project has been built with pyside6 since the beginning, which would imply that there may only have been compatibility with qt6.x, so supporting 10.15 (with QT 5.x) by going to an older version may not be possible after all.

I assume the answer is no, but there isn't by chance a headless version without a GUI? I really just want some text file updates with the current track and I can pick it up from there.

@aw-was-here
Copy link
Collaborator

aw-was-here commented Nov 21, 2023

Looks like Qt 6.2 is supposed to work on 10.14+? But yes, WNP has been using PySide6 for a very long time. 3.0.0 is the last tagged release that was built prior to PySide6.

edit: added link to requirements.txt with pyside2

@booherbg
Copy link
Author

booherbg commented Nov 21, 2023

Looks like Qt 6.2 is supposed to work on 10.14+? But yes, WNP has been using PySide6 for a very long time. 3.0.0 is the last tagged release that was built prior to PySide6.

Oh, I missed that. Thank you. The reference I found only included 6.5 and 6.6.

edit: ah, if you change the url to qt-6.4/macos.html its there. Thank you, I'll play around with this!
https://doc.qt.io/archives/qt-6.4/macos.html

@booherbg
Copy link
Author

If I am correct in my assumption that PySide versioning tracks Qt versioning, then I should take a bet on the latest version before the transition to Qt 6.5. Looks like v4.0.1 is a good place to start as it sets the PySide version to 6.4.2

@booherbg
Copy link
Author

Quick update, v4.0.1 builds fine but has a slightly different Qt error:

Error: Sorry, "rcc" cannot be run on this version of macOS. Qt requires macOS 11.0.0 or later, you have macOS 10.15.7.

However, I do see that there is binary compatibility with 10.14+ under the 3.1.3 branch, so I am hopeful :)

@booherbg
Copy link
Author

booherbg commented Nov 21, 2023

Final update: I cannot even build 3.1.3 from source, because I still get the same error about rcc. However, I CAN run the 3.1.2 binary which is built for OSX 10.14+. Thank you!

My best guess is that the build can be built to target 10.14 only if it is built on a newer versions of OSX that has the full Qt toolchain? Or maybe something got busted on my system as I installed and uninstalled all of these dependencies.

If there is any chance that one of the devs can try a build from the v4.0.1 branch targeting 10.14 (which should be compatible still, as noted above), I'd be happy to try it out!

@aw-was-here Please accept my sincere thank you for your help and quick response! I now have a working version of Now Playing v3.1.2 running on Catalina.

@aw-was-here
Copy link
Collaborator

If there is any chance that one of the devs can try a build from the v4.0.1 branch targeting 10.14 (which should be compatible still, as noted above), I'd be happy to try it out!

OK, I pulled out my old Mojave machine and tracked down the issue.

PySide6 6.5.x is just completely broken on older releases. Installing with 6.4.x appears to work. I've opened a PR to change the requirements-run.txt file to avoid the broken version. Looks like an unrelated unit test is failing, but I'll merge in anyway.

@aw-was-here
Copy link
Collaborator

Note that using the ./builder.sh macosx script should do everything at this point to build a local copy, at least on Mojave/10.14 with Python 3.10 with the top of the main branch. Python 3.11 is still not supported and Python 3.9 will likely not work.

@booherbg
Copy link
Author

Thank you for taking a look at this! On the main branch, the build still works fine after the update, but rcc still bombs out when running (interesting, Syntax error?)
image

@aw-was-here
Copy link
Collaborator

aw-was-here commented Nov 25, 2023

For some reason, it isn't picking up the python3 or python-rcc from the virtual environment that builder.sh is building. What does the beginning of executing the script look like?

@aw-was-here
Copy link
Collaborator

Put a change in #969 to make builder a bit smarter that also might help fix your issue.

@aw-was-here
Copy link
Collaborator

If I get a chance, I'll try to make a build for 4.20-rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants