Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for federated token binding to fetch #30

Closed
balfanz opened this issue Mar 30, 2015 · 10 comments
Closed

Add support for federated token binding to fetch #30

balfanz opened this issue Mar 30, 2015 · 10 comments
Labels
addition/proposal New features or enhancements

Comments

@balfanz
Copy link

balfanz commented Mar 30, 2015

I'm proposing to add support for (federated) Token Binding to fetch.

I've written a requirements/problem-description document for a Token Binding DOM API: https://docs.google.com/document/d/1x_3KI_v35NQFEsAbGGjNcyTw3Waoy1mL3YfTaQbyyuM/view?rm=minimal&pli=1

While I have included a strawman proposal in the doc, I'd appreciate help from the fetch editors/implementers to figure out what the right approach is.

@annevk
Copy link
Member

annevk commented Mar 31, 2015

I filed a couple of issues https://github.com/TokenBinding/Internet-Drafts/issues as some things were not entirely clear to me.

It seems there needs to be integration between Fetch and this draft where Fetch handles redirects (or is Include-Referer-Token-Binding-ID not relevant for the API?), where Fetch goes to the network (and "adds" HTTP headers), and with the API.

So we probably need to decide what bits of the processing model should be in Fetch and what should be handled in those drafts and then how to best divide that.

@balfanz
Copy link
Author

balfanz commented Mar 31, 2015

Include-Referer-Token-Binding-ID shouldn't be relevant for this API. That's a different way for the RP to signal to the UA to reveal the referred token-binding to the IdP. Federation protocols that use redirects would use the Include-Referer-Token-Binding-ID header, and federation protocols that use XHRs would use whatever capabilities fetch exposes for that - but you wouldn't see RPs use both.

On the other hand, anything on the client that processes redirects should be aware of this new response header - if redirection logic is handled by fetch then I guess that's something that it should be aware of.

We'll have new versions of the Token Binding I-Ds out soon. We'll address the issues you and others have pointed out over there.

@annevk
Copy link
Member

annevk commented Mar 31, 2015

Yes, Fetch handles all requesting logic for the entire web platform, including redirects. Redirects are handled in step 4 of https://fetch.spec.whatwg.org/#http-fetch at the moment. Headers such as cookies and Referer are added at the network level here: https://fetch.spec.whatwg.org/#concept-http-network-or-cache-fetch

I suspect both of these need to be modified somehow to account for Token-Binding. I suspect we want to update the concept of a request somehow with a flag that indicates that Token-Binding needs to be included in the request. (What happens if such a request results in a(nother) redirect?)

@annevk
Copy link
Member

annevk commented May 5, 2015

@balfanz do you need anything else from me?

@balfanz
Copy link
Author

balfanz commented Jun 30, 2015

@annevk - any pointers as to how to get this moved to the next stage would be great. Should I attend a meeting somewhere?

As for the redirect question: I think we should include the referred token-binding only in the first request - the one that the 302 redirects to, or the one that the fetch() initially goes to.

@annevk
Copy link
Member

annevk commented Jun 30, 2015

We don't have meetings really, but I'm happy to chat if you think that helps.

If you search for "mixed content" in Fetch you'll find how it integrates with the Mixed Content specification. Ideally, we'd have something similar for federated token binding. A set of changes to the Fetch algorithm and API that integrates with the work done at the IETF.

@annevk annevk added the addition/proposal New features or enhancements label Jan 7, 2016
@annevk
Copy link
Member

annevk commented May 13, 2017

A feature of Token Binding is that it couples requests with their connection. What is the impact of that on efforts to reuse connections across credentialed and non-credentialed requests (see #341)?

cc @vanupam @mikewest @yoavweiss @equalsJeffH @sleevi @jakearchibald

@sleevi
Copy link

sleevi commented May 13, 2017 via email

@annevk
Copy link
Member

annevk commented May 13, 2017

Okay, that sounds somewhat promising. I got worried because in the PR there's talk about putting new properties on the connection, but I have not carefully studied the implications.

@annevk
Copy link
Member

annevk commented Jan 30, 2021

Closing as per #715 (comment).

@annevk annevk closed this as completed Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition/proposal New features or enhancements
Development

Successfully merging a pull request may close this issue.

3 participants