-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for federated token binding to fetch #30
Comments
I filed a couple of issues https://github.com/TokenBinding/Internet-Drafts/issues as some things were not entirely clear to me. It seems there needs to be integration between Fetch and this draft where Fetch handles redirects (or is So we probably need to decide what bits of the processing model should be in Fetch and what should be handled in those drafts and then how to best divide that. |
Include-Referer-Token-Binding-ID shouldn't be relevant for this API. That's a different way for the RP to signal to the UA to reveal the referred token-binding to the IdP. Federation protocols that use redirects would use the Include-Referer-Token-Binding-ID header, and federation protocols that use XHRs would use whatever capabilities fetch exposes for that - but you wouldn't see RPs use both. On the other hand, anything on the client that processes redirects should be aware of this new response header - if redirection logic is handled by fetch then I guess that's something that it should be aware of. We'll have new versions of the Token Binding I-Ds out soon. We'll address the issues you and others have pointed out over there. |
Yes, Fetch handles all requesting logic for the entire web platform, including redirects. Redirects are handled in step 4 of https://fetch.spec.whatwg.org/#http-fetch at the moment. Headers such as cookies and I suspect both of these need to be modified somehow to account for |
@balfanz do you need anything else from me? |
@annevk - any pointers as to how to get this moved to the next stage would be great. Should I attend a meeting somewhere? As for the redirect question: I think we should include the referred token-binding only in the first request - the one that the 302 redirects to, or the one that the fetch() initially goes to. |
We don't have meetings really, but I'm happy to chat if you think that helps. If you search for "mixed content" in Fetch you'll find how it integrates with the Mixed Content specification. Ideally, we'd have something similar for federated token binding. A set of changes to the Fetch algorithm and API that integrates with the work done at the IETF. |
A feature of Token Binding is that it couples requests with their connection. What is the impact of that on efforts to reuse connections across credentialed and non-credentialed requests (see #341)? cc @vanupam @mikewest @yoavweiss @equalsJeffH @sleevi @jakearchibald |
Token Binding's predecessors (Channel ID, Origin Bound Certs) is why Chrome
originally introduced the pooling it did.
Token Binding's design (to be at the H/2 Req/Response layer) was
particularly trying to address some of these deficiencies and make it
easier to reuse the same connection.
We have not yet modeled the privacy and security properties of referred
Token Binding into the credentialed access case to determine what reuse or
separation is needed. Since TB tries to mimic a request-oriented auth flow,
hopefully the properties are similar.
|
Okay, that sounds somewhat promising. I got worried because in the PR there's talk about putting new properties on the connection, but I have not carefully studied the implications. |
Closing as per #715 (comment). |
I'm proposing to add support for (federated) Token Binding to fetch.
I've written a requirements/problem-description document for a Token Binding DOM API: https://docs.google.com/document/d/1x_3KI_v35NQFEsAbGGjNcyTw3Waoy1mL3YfTaQbyyuM/view?rm=minimal&pli=1
While I have included a strawman proposal in the doc, I'd appreciate help from the fetch editors/implementers to figure out what the right approach is.
The text was updated successfully, but these errors were encountered: