Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What task is the end of "Navigating to a fragment" talking about? #3491

Closed
bzbarsky opened this issue Feb 22, 2018 · 6 comments
Closed

What task is the end of "Navigating to a fragment" talking about? #3491

bzbarsky opened this issue Feb 22, 2018 · 6 comments
Labels
good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@bzbarsky
Copy link
Contributor

The last sentence of the section that starts at https://html.spec.whatwg.org/multipage/browsing-the-web.html#scroll-to-fragid is:

The task source for the task mentioned in this section must be the DOM manipulation task source.

But the only mention of the word "task" in that whole section is:

Remove any tasks queued by the history traversal task source that are associated with any Document objects in the top-level browsing context's document family.

which is not even queuing a task. So what is that last sentence talking about?

@annevk
Copy link
Member

annevk commented Feb 22, 2018

The task source was defined in 1465cd9 because at the time navigating to a fragment identifier would queue a task. Then d0d9b65 removed the task to align with reality, but forgot about this sentence. I'll post a PR.

@annevk annevk added the good first issue Ideal for someone new to a WHATWG standard or software project label Feb 22, 2018
@annevk
Copy link
Member

annevk commented Feb 22, 2018

Actually, let's make this a good first issue. The objective is to remove

The task source for the task mentioned in this section must be the DOM manipulation task source.

from the source resource as it's no longer accurate. Bonus points if the commit message body captures the history from my comment above.

@bzbarsky
Copy link
Contributor Author

Then d0d9b65 removed the task to align with reality

Yikes. Filed #3497 on this bit. :(

@rahulpurohit29
Copy link
Contributor

So particularly only have to remove the text above and commit message with the history in the comment.

@annevk
Copy link
Member

annevk commented Aug 16, 2018

@rahulpurohit29 yes, ideally the commit message explains why that sentence was there and why it's no longer relevant now.

@domenic
Copy link
Member

domenic commented Jun 16, 2021

This has been fixed.

@domenic domenic closed this as completed Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for someone new to a WHATWG standard or software project
Development

No branches or pull requests

4 participants