Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review.sh: make it easier to overwrite a copy #390

Open
annevk opened this issue Feb 23, 2022 · 0 comments
Open

review.sh: make it easier to overwrite a copy #390

annevk opened this issue Feb 23, 2022 · 0 comments

Comments

@annevk
Copy link
Member

annevk commented Feb 23, 2022

Review Draft publication goes relatively well (though see #348) as per https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#review-drafts. One problem is recovering from build failures.

When hitting a build failure my current process is something like this:

  1. Create a separate PR to address the build failure.
  2. Rebase the RD PR.
  3. Change the review.sh script by commenting out four lines (starting with git checkout main) to avoid it creating a new branch.
  4. Make review.sh executable via chmod 755 review.sh (755 is prolly too much?).
  5. Run it.
  6. Rebase the RD PR again folding the new commit into the previous one.
  7. Force push.
  8. Hopefully all is well now.

Step 1 is always needed. Ideally step 2 through 7 would be replaced by a single step, e.g., ./review.sh redo.

Anyone else have thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant