Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ParsedWheelFilename to a dataclass #7

Open
jwodder opened this issue Nov 5, 2023 · 1 comment · May be fixed by #15
Open

Change ParsedWheelFilename to a dataclass #7

jwodder opened this issue Nov 5, 2023 · 1 comment · May be fixed by #15
Labels
breaking change Introduction of an incompatible API change easy Not hard
Milestone
v2.0

Comments

@jwodder
Copy link
Collaborator

jwodder commented Nov 5, 2023

Also, change the list fields to tuples.

Consider "freezing" the class as well.
@jwodder jwodder added the breaking change Introduction of an incompatible API change label Nov 5, 2023
@jwodder jwodder added this to the v2.0 milestone Nov 5, 2023
@jwodder jwodder added the easy Not hard label Dec 7, 2023
@shakfu
Copy link

shakfu commented Jan 10, 2024

Couldn't agree more. I just changed NamedTuple to a data class and it was a drop-in replacement and allowed for fields to be changed.

@mtrd3v mtrd3v linked a pull request Aug 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Introduction of an incompatible API change easy Not hard
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Changed NamedTuple to DataClasses. mtrd3v/wheel-filename
2 participants
@jwodder @shakfu