Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign @stlite/desktop's dump command API #853

Closed
whitphx opened this issue Apr 4, 2024 · 2 comments · Fixed by #878
Closed

Redesign @stlite/desktop's dump command API #853

whitphx opened this issue Apr 4, 2024 · 2 comments · Fixed by #878

Comments

@whitphx
Copy link
Owner

whitphx commented Apr 4, 2024

  • Its options which we are now passing as command line args, e.g. the app directory and the requirements, should be defined in package.json.
    • Such file-based build config is more consistent and useful.
  • Support an arbitrary entrypoint name.
  • Support -p option like tsc to specify the project root dir where package.json exists. It's not fixed to process.cwd().

We should keep the current dump command marking it deprecated and create a new one for the compatibility.

@terapyon
Copy link

terapyon commented Apr 4, 2024

"e.g. the app directory" : Does this mean that we can use another app name for "streamlit_app"? If yes, it is very very useful. If no set for app name in package.json, to expect using streamlit_app.py.

@whitphx
Copy link
Owner Author

whitphx commented Apr 5, 2024

Thank you. Yes, I'm planning to allow any app name with such settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants