Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari support information #1

Closed
TomasHubelbauer opened this issue Jul 8, 2024 · 4 comments
Closed

Safari support information #1

TomasHubelbauer opened this issue Jul 8, 2024 · 4 comments

Comments

@TomasHubelbauer
Copy link

Hi, as per https://github.com/wide-video/app-ffmpeg/blob/main/TODO.md there is testing needed for Safari. I gave it a quick spin.

First I tried this in Firefox to get a baseline of excepted behavior: I dragged in a JPG file and used ffmpeg -i autumn-5k-peter-k-burian.jpg -preset ultrafast output.png to convert to PNG. The output.png file was created in the virtual FS as well as its preview was displayed after the command ran. The WASM related bits got pulled in and executed successfully.

I didn't test a video or audio conversion, but I assume since the image conversion works, everything will.

The only problem is the lack of blinking cursor in the terminal on Firefox.

Next I tried to do the same on Safari and I was able to drag in the file as well. I then tried to use ls to check it was on the virtual FS, but I couldn't type into the terminal at all on Safari. I couldn't try any other steps as a result. There are no errors in the console. I am on macOS Sonoma 14.5.

Let me know if you need any other help with Safari/Firefox testing on macOS.

@jozefchutka
Copy link
Collaborator

jozefchutka commented Jul 8, 2024

Hi Tomas,

thanks for reporting. I will have a look on the firefox issue with cursor today and will have access to mac/safari tomorrow - will fix the necessary.

@jozefchutka
Copy link
Collaborator

firefox caret fixed in 7a78a8f

@jozefchutka
Copy link
Collaborator

fixed safari cared in fa91844

@TomasHubelbauer
Copy link
Author

Can confirm both work for me now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants