Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with broadcast folder #13

Open
0xCalibur opened this issue May 29, 2023 · 1 comment
Open

Issues with broadcast folder #13

0xCalibur opened this issue May 29, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@0xCalibur
Copy link

0xCalibur commented May 29, 2023

It might an harder problem to tackle but forge-deploy doesn't play well if you have files inside broadcasts/ that were deployed without forge-deploy, using barebone forge scripts.

Also, If I delete a deployment file so that it is forced re-deployed, forge-deploy sync is going to add back some of the old deployment back (if I didn't redeployed them yet).

Anyway, lots of small issues that prevents a fire-and-forget-about-it deploying experience.

My workaround for now is to rm -rf broadcast/ folder after every forge-deploy sync.

@wighawag
Copy link
Owner

wighawag commented Jun 9, 2023

yes, I was foreseing this kind of issues

for issue 1, I am surprised it is causing an issue as I thought forge-deploy would skip things not matching its format. I ll investigate

for issue 2, I need to add a timestamp somewhere to not resync each time

Thanks again for reporting all these issues. this helps a lot

@wighawag wighawag added the bug Something isn't working label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants