Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace go get with go install to download and install requiring building tools #240

Closed
yersan opened this issue Nov 7, 2022 · 0 comments · Fixed by #283
Closed

Replace go get with go install to download and install requiring building tools #240

yersan opened this issue Nov 7, 2022 · 0 comments · Fixed by #283

Comments

@yersan
Copy link
Collaborator

yersan commented Nov 7, 2022

There are several targets at the make file that automatically download and install the required tools if they are not yet available locally. For example, the following tools are automatically downloaded and installed when required by the make target:

  • controller-get
  • customize

They are downloaded and installed by calling go-get-tool, which is just a function that uses the go get in an empty module to make the trick to get them installed.

This go get has been deprecated since go 1.17 and removed and replaced by go install in go 1.19.

The task here is to replace how we are installing the building tools with go install command. These tools should be installed atn the project bin directory, for example, something like this could work to install the controller-gen:

GOBIN=$(pwd)/bin go install sigs.k8s.io/controller-tools/cmd/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant