-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in OEP wind_turbine_library causes fails in windpowerlib #100
Comments
Thanks for testing and spotting! |
@christian-rli could you please just remove the line, because this bug can make the windpowerlib unusable. Most users will not be able to fix it. For the future we should think of how to avoid such issues. |
I removed the line by hand since @christian-rli is not available this week. |
We could add a column |
Thank you @Ludee 👍 |
That's a good idea. Another idea is to validate the data in the windpowerlib when importing. |
I think we should do both. The windpowerlib should not be vulnerable by corrupt data sets and the oep should make sure that it does not provide corrupt data. |
I addressed this issue in PR #101 and added an issue in the OEP-repository. |
The turbine with turbine_id 152 in supply/wind_turbine_library is corrupt:
In
power_curve_wind_speeds
you will find duplicate values causing errors in the data processing of the windpowerlib as the windspeed are used as columns.The text was updated successfully, but these errors were encountered: