From c2065ba291a9977da34e8d6d71f13a2e8326b523 Mon Sep 17 00:00:00 2001 From: Roman Gilg Date: Wed, 1 Apr 2020 20:55:20 +0200 Subject: [PATCH] test: disable check on second remote access param The check failed sporadically but more than often enough on CI under high load. The spy connection is just too racy. That holds for all signal spies but here it really happens too often. Long-term we need to find a general solution for this problem. That is also a prerequisite for solving issue #12. (cherry picked from commit e44986d4abd597153ffbf3d41b3f5f249df4bda9) --- autotests/client/test_remote_access.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/autotests/client/test_remote_access.cpp b/autotests/client/test_remote_access.cpp index 5bac7bd1..8863441a 100644 --- a/autotests/client/test_remote_access.cpp +++ b/autotests/client/test_remote_access.cpp @@ -293,8 +293,12 @@ void RemoteAccessTest::testSendReleaseMultiple() QVERIFY(paramsObtainedSpy1.size() == 1 || paramsObtainedSpy1.wait()); QCOMPARE(paramsObtainedSpy1.size(), 1); + // TODO: This signal spy connection is still too racy and fails too often under high load on CI. + // For now disable the check and try to find a solution as part of issue #12. +#if 0 QVERIFY(paramsObtainedSpy2.size() == 1 || paramsObtainedSpy2.wait()); QCOMPARE(paramsObtainedSpy2.size(), 1); +#endif // release QSignalSpy bufferReleasedSpy(m_remoteAccessInterface, &RemoteAccessManagerInterface::bufferReleased); @@ -440,7 +444,7 @@ void RemoteAccessTest::testSendClientGone() void RemoteAccessTest::testSendReceiveClientGone() { - // this test verifies that when buffer is sent, received and client is gone, + // this test verifies that when buffer is sent, received and client is gone, // both client and server will release buffer correctly QVERIFY(!m_remoteAccessInterface->isBound()); auto *client = new MockupClient(this);