[fix] Ensure that logger.log("info", undefined) does not throw. Fixes

#739.
winstonjs · Nov 3, 2015 · 1f16861 · 1f16861
1 parent 795cdd9
commit 1f16861
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/winston/logger.js b/lib/winston/logger.js
@@ -166,7 +166,7 @@ Logger.prototype.log = function (level) {
   //    logger.info('No interpolation symbols', 'ok', 'why', { meta: 'is-this' });
   //
   var metaType  = Object.prototype.toString.call(args[args.length - 1]),
-      fmtMatch  = args[0].match && args[0].match(formatRegExp),
+      fmtMatch  = args[0] && args[0].match && args[0].match(formatRegExp),
       isFormat  = fmtMatch && fmtMatch.length,
       validMeta = !isFormat
         ? metaType === '[object Object]' || metaType === '[object Error]' || metaType === '[object Array]'

diff --git a/test/logger-test.js b/test/logger-test.js
@@ -281,6 +281,9 @@ vows.describe('winton/logger').addBatch({
       ]
     }),
     "the log() method": {
+      "when passed undefined should not throw": function (logger) {
+        assert.doesNotThrow(function () { logger.log('info', undefined) });
+      },
       "when passed an Error object as meta": {
         topic: function (logger) {
           logger.once('logging', this.callback);