Block access to sensitive field data for unauthorized users

[seanthepottingshed]

• Winter CMS Build: Latest
• PHP Version: 7.2
• Database Engine: mysql
• Plugins Installed: N/A

Description

Setting a sensitive form field to readOnly doesn't stop the display of the password when clicking the view button.

Steps To Reproduce:

And the following to fields.yaml:

test_api_key:
    label: Test API key
    placeholder: Enter key
    type: sensitive
    readOnly: true

[LukeTowers]

I'm curious as to why you think readOnly should prevent that, technically they're not editing the field, only reading it. What's the use case you're trying to achieve?

[seanthepottingshed]

Good point, maybe it's just me but it seems counterintuitive to be able to interact with a field that is set to readOnly, I assumed it would just display as a password field type instead.

[LukeTowers]

I'm not really sure what the point of that happening would be tbh, are you trying to hide the sensitive data from unprivileged users?

[seanthepottingshed]

Sorry yes, I worked around it by serving different fields based upon user permission. So user with privileges gets field as sensitive otherwise as readOnly password

[LukeTowers]

There are other ways you can achieve similar results too, for example you could hook into the backend.ajax.beforeRunHandler event and throw an ApplicationException if you detect someone is trying to onShowValue() without the correct level of access to the data.

Is there anything actionable left in this issue or are you fine with your current solution?

[seanthepottingshed]

There are other ways you can achieve similar results too, for example you could hook into the backend.ajax.beforeRunHandler event and throw an ApplicationException if you detect someone is trying to onShowValue() without the correct level of access to the data.

Good to know!