Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MySQL WEEKDAY #6

Closed
webdevilopers opened this issue Sep 18, 2014 · 8 comments
Closed

Add support for MySQL WEEKDAY #6

webdevilopers opened this issue Sep 18, 2014 · 8 comments

Comments

@webdevilopers
Copy link

A good example by @ionafan2 can be found and is still waiting in the original @beberlei fork here:

@webdevilopers
Copy link
Author

Also requested this feature for OroCRM here:
oroinc/doctrine-extensions#4

@webdevilopers
Copy link
Author

@stevelacey
Copy link

@webdevilopers I am the original author of this repo, but no one seems to maintain it anymore – if you were to submit a PR to https://github.com/stevelacey/doctrine-extensions – I'd be happy to merge it and continue maintaining from there.

@webdevilopers
Copy link
Author

Actually there has been a short discussion about adding a WEEKDAY extension or using the almost identical function DAYOFWEEK @stevelacey :
oroinc/doctrine-extensions#4 (comment)

I prefer WEEKDAY starting with index 0 for mondayin my use case.

What do you think? Do you think "another" `DoctrineExtensions" Repo will "survive"? ;)

@stevelacey
Copy link

I am happy to merge support for any MySQL functions that are unsupported natively if it doesn't cause any issues and is something someone wants.

With regards to the repo, the main reason these things go unmaintained is because GitHub notifications are whack, so everyone disables the emails – and then only get them when someone @'s them – new issues/PR's etc don't trigger an email alone – so there's radio silence... I've fixed mine now and set them up for only stuff I care about, which includes the new repo – so as I said, PR there, and I'll happily merge 😃 thanks.

@webdevilopers
Copy link
Author

I would also add full support for GROUP_CONCAT by @denisvmedia in issue #3.

I saw @beberlei looking for a new maintainer of his fork:
https://twitter.com/beberlei/status/563671147636875264

Maybe we should wait if he has any good news for us?

@stevelacey
Copy link

An implementation of this is now merged into https://github.com/beberlei/DoctrineExtensions

@webdevilopers
Copy link
Author

Merged in beberlei#110. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants