Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] Replaceos.path with Pathlib #190

Open
formatc1702 opened this issue Oct 24, 2020 · 1 comment · Fixed by #246
Open

[internal] Replaceos.path with Pathlib #190

formatc1702 opened this issue Oct 24, 2020 · 1 comment · Fixed by #246
Milestone
v0.4

Comments

@formatc1702
Copy link
Collaborator

formatc1702 commented Oct 24, 2020 •
edited
Loading

Remove all references to os.path in the code and replace with the equivalents using Pathlib for consistency and robustness.

This includes reducing all type hints from (str, Path) to Path.
@formatc1702 formatc1702 added this to the v0.3 milestone Oct 24, 2020
@formatc1702
Copy link
Collaborator Author

Perhaps @n42 can explain the need for adding the .. in line 13 in wireviz.py? Isn't it enough to insert os.path.dirname(__file__) to find the WireViz modules?

Would the Pathlib equivalent then be Path(__file__).parent? Thanks :)

@formatc1702 formatc1702 mentioned this issue Aug 23, 2021
Open
@formatc1702 formatc1702 mentioned this issue Oct 7, 2021
Merged
@formatc1702 formatc1702 modified the milestones: v0.3, v0.4 Oct 11, 2021
@martinrieder martinrieder mentioned this issue Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

Replace os.path with pathlib.Path wireviz/WireViz
1 participant
@formatc1702