Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Alphanumeric pin designators #336

Closed
martinrieder opened this issue May 2, 2024 · 1 comment
Closed

[feature] Alphanumeric pin designators #336

martinrieder opened this issue May 2, 2024 · 1 comment

Comments

@martinrieder
Copy link
Contributor

martinrieder commented May 2, 2024

I have been working with the latest release of WireViz quite happily, not realizing the huge amount of improvement done in the dev branch. For my work with some connectors that are using alphanumeric pin designators, I needed to make a minor change in the DataClasses by simply replacing the int with str:

Pin = Union[str, PlainText] # Pin identifier

Then, in order to make Graphviz properly assign the wires, I also had to replace {pinindex+1} by the {pinname} in the HTML table output. Due to #229, this probably will not be necessary, but please let me know if I am missing something.

pinhtml.append(f' <td port="p{pinname}r">{pinname}</td>')

I cannot see that it was possible to create pin identifiers from a string like suggeted in #160 without the suggested change above. See the example that it works well for my use case:

Example-Harness-Adapter

@martinrieder martinrieder closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
@martinrieder
Copy link
Contributor Author

Sorry for this report by mistake. I wanted to confirm my statements by freshly reinstalling 0.3.2 from PyPy, but could not reproduce the issue. Not sure what I was doing wrong in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant