Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Make Harness.output method more consistent #82

Closed
slightlynybbled opened this issue Jul 13, 2020 · 1 comment
Closed

[internal] Make Harness.output method more consistent #82

slightlynybbled opened this issue Jul 13, 2020 · 1 comment

Comments

@slightlynybbled
Copy link
Contributor

Looking at this line

For anyone who wishes to use Harness.output method directly, there is a parameter called directory. If directory is utilized, then all of the output files are not saved to the same place (.bom.tsv and .html). The workaround is use filename with an absolute path and leave directory blank.

I am happy to submit a pull request to fix this, but there are two options and I am not sure which the author wishes to engage:

Option 1. Eliminate the directory and ensure that filename is always a valid path (recommend using pathlib and making filename and instance of pathlib.Path).

Option 2. Insert directory into the .bom.tsv and .html directories.

I look forward to author's guidance on this.

@slightlynybbled slightlynybbled changed the title [internal] Make Harness.output methodmore consistent [internal] Make Harness.output method more consistent Jul 13, 2020
@formatc1702
Copy link
Collaborator

In the interest of simplicity, I would go for option 1 and eliminate directory completely, since it's just as easy to include it in filename directly.

This issue is related to #60 (and indirectly, to #55); handling of file output needs some cleaning up.
If you're willing to submit a PR that fixes both issues, I'd be more than happy to include it! Any help in this regard is appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants