🐛 astro add vercel fails in a misleading way

[mayank99]

What version of astro are you using?

1.0.0-beta.63

Are you using an SSR adapter? If so, which one?

Vercel, but it applies to all SSR adapters

What package manager are you using?

npm

What operating system are you using?

Windows

Describe the Bug

I tried running npx astro add vercel (not sure why I just assumed it should work, probably because the difference between adapters and integrations is not obvious). Running that successfully installed the @astrojs/vercel package but it had the wrong import path in astro.config and it was calling the adpater under the integrations: field instead of the adapter:. Also it was missing the ENABLE_VC_BUILD: 1 env var. All of these things are correctly mentioned in the @astrojs/vercel README but I had to manually find that link.

The problem here is not that astro add doesn't support adapters (which is just a missing feature). The problem is that it doesn't stop you from running astro add vercel or astro add netlify. It even gives the false impression that it is making the right config changes. Ideally, passing an unsupported name or flag to astro add should just fail, and optionally even link to the docs for manually configuring adapters correctly.

---

Another scenario: I'd imagine this same problem will happen when there are other packages added under the @astrojs scope in the future, e.g. @astrojs/markdown. Meanwhile, running npx astro add foo successfully fails because there is no @astrojs/foo package.

Maybe the add script should only allow a small hardcoded list of integrations that it's known to support, and fail if anything else is passed?

Link to Minimal Reproducible Example

N/A

Participation

• I am willing to submit a pull request for this issue.