Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions are incorrect in Windows Terminal after resize #1707

Open
3 tasks done
sullivan-sean opened this issue Aug 20, 2022 · 0 comments
Open
3 tasks done

Suggestions are incorrect in Windows Terminal after resize #1707

sullivan-sean opened this issue Aug 20, 2022 · 0 comments
Assignees
Labels
os:windows Issues related to Windows terminal:WindowsTerminal Issues related to Windows Terminal type:bug Something isn't working

Comments

@sullivan-sean
Copy link

sullivan-sean commented Aug 20, 2022

Sanity checks

  • I have searched github.com/withfig/fig/issues and there are no duplicates of my issue
  • I have run fig doctor in the affected terminal session
  • I have run fig restart and tested again (tell us if that fixed it)

Issue Details

Description:

In Windows Terminal, resizing sometimes causes fig to offer incorrect suggestions or no suggestions at all. In particular, if a user has already typed some text in the terminal like cd and then resizes the window in a particular way, Fig's internal representation of the terminal will mark all of the text as prompt, meaning that suggestions will start from the end of the text. Typing ls will behave as an empty buffer and provide no suggestions while typing ls with 3 spaces at the start (for the length of cd ) will provide correct suggestions.

This is a direct consequence of our workaround for microsoft/terminal#8698 (or the more specific duplicate microsoft/terminal#11220) which attempts to delay OSCs for prompt end. On the bright side it looks like there is activity on this ticket in Windows Terminal and it may be fixed soon.

Fortunately, this issue with suggestions will also go away at the next prompt. This is a low priority known-bug, but if you are affected please upvote or comment, we can increase priority if this is encountered sufficiently often

@sullivan-sean sullivan-sean added os:windows Issues related to Windows terminal:WindowsTerminal Issues related to Windows Terminal labels Aug 20, 2022
@sullivan-sean sullivan-sean self-assigned this Aug 20, 2022
@sullivan-sean sullivan-sean added the type:bug Something isn't working label Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os:windows Issues related to Windows terminal:WindowsTerminal Issues related to Windows Terminal type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant