Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Android): RN instance listener - dynamic proxies for the rescue #3508

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Jul 27, 2022

Description

This is work made on top of #3504 (details within), which hadn't seemed to haved successfully resolve the issue.
Fixes #3492.

@d4vidi d4vidi requested a review from jonathanmos as a code owner July 27, 2022 12:18
@d4vidi d4vidi requested a review from asafkorem July 27, 2022 12:18
@d4vidi d4vidi self-assigned this Jul 27, 2022
@d4vidi d4vidi merged commit 673bc62 into master Jul 27, 2022
@d4vidi d4vidi deleted the fix-rn67-load-fail2 branch July 27, 2022 13:35
@asafkorem
Copy link
Contributor

Amazing

private interface DummyListenerIdentifier

/**
* This baby bridges over RN's breaking change introduced in version 0.68:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RN 68] Android backwards compatibility (RN .64): test project
2 participants