[Android] Remove @override annotation to support RN 0.53-0.55 on detox 9.0

[JamesWatling]

remove @OverRide annotation on onBridgeDestroyed as it is not introduced until react-native 0.56 and breaks previous react-native versions

See #919

The NotThreadSafeBridgeIdleDebugListener interface doesn't add the method onBridgeDestroyed() until RN 0.56 this causes builds prior than that to break with an error as follows:

Task :detox:compileMinReactNative46DebugJavaWithJavac FAILED
.../node_modules/detox/android/detox/src/main/java/com/wix/detox/espresso/ReactBridgeIdlingResource.java:65: error: method does not override or implement a method from a supertype
    @Override
    ^
Note: .../node_modules/detox/android/detox/src/main/java/com/wix/detox/espresso/MultiTap.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

This simply removes the @Override annotation without changing the expected functionality

[hazen]

Thanks, @JamesWatling , I saw the same issue

[rotemmiz]

Thanks for this PR!

This is weird, I can't see the CI integration here. @yershalom , any idea what happened ?

[yershalom]

@rotemmiz nope.
@JamesWatling Can you please push some dummy commit, so it will trigger our CI?

[JamesWatling]

@rotemmiz @yershalom weird. I just pushed an empty commit and it still isn't triggered...

Is there anyway for it to be manually triggerred?

[rotemmiz]

@yershalom I started getting notifications from GitHub named wix/Detox instead of wix/detox. Maybe this is somehow related?

[JamesWatling]

It looks like the project name changed? If I look back to last month it was wix/detox, and now it's wix/Detox. Maybe the Jenkins needs to be updated too

[yershalom]

@rotemmiz who changed it? And yes, this is related

[rotemmiz]

No idea

[yershalom]

Change it back?

[rotemmiz]

I guess, yes

[yershalom]

Mk

[yershalom]

@JamesWatling can you please push another dummy commit?
And sorry for the trouble.

[hazen]

Any chance we could get a tag for this change? 9.0.2? Thanks!

[phosphene]

Yes. Looking forward to the next version bump to 9.0.2 that includes this change.