Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't dismissModal without animation #4117

Closed
smokokoi opened this issue Oct 10, 2018 · 2 comments
Closed

Can't dismissModal without animation #4117

smokokoi opened this issue Oct 10, 2018 · 2 comments

Comments

@smokokoi
Copy link

smokokoi commented Oct 10, 2018

dissmissModal on iOS is always animated. I tried to dismiss it without animation using the following command:

Navigation.dismissModal(componentID, {
        animations: {
          dismissModal: {
            enable: false,
          }
        }
    });
@guyca guyca assigned yogevbd and unassigned guyca Oct 10, 2018
@guyca guyca changed the title can't dismissModal without animation on iOS (navigation v2) Can't dismissModal without animation Oct 10, 2018
@yogevbd
Copy link
Collaborator

yogevbd commented Oct 17, 2018

Replacing enable with enabled should solve this on iOS

Navigation.dismissModal(componentID, {
        animations: {
          dismissModal: {
            enabled: false,
          }
        }
    });

@yogevbd yogevbd assigned guyca and unassigned yogevbd Oct 17, 2018
@yogevbd yogevbd closed this as completed Oct 18, 2018
@yogevbd yogevbd reopened this Oct 18, 2018
@smokokoi
Copy link
Author

@yogevbd @guyca - it seems I can't dismiss a modal without animation on both platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants