Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instructions for launching playground app are out of date #4582

Closed
Pushplaybang opened this issue Jan 14, 2019 · 5 comments
Closed

instructions for launching playground app are out of date #4582

Pushplaybang opened this issue Jan 14, 2019 · 5 comments

Comments

@Pushplaybang
Copy link

Issue Description

Following the documentation instructions for running the playground app do not work. This seems largely due to the clone command shown, referencing the old v2 branch, which now seems out of date with master, where there have been a number of fixes, such as the issues with xcode 10.x #4321 #3608 etc

Steps to Reproduce / Code Snippets / Screenshots

follow the playground setup documentation exactly.
https://wix.github.io/react-native-navigation/#/docs/showcases

Solution:

the first line should be changed from:

git clone -b v2 [email protected]:wix/react-native-navigation.git

to:

git clone -b master [email protected]:wix/react-native-navigation.git

Environment

  • React Native Navigation version: PLAYGROUND INSTRUCTIONS PULL THE WRONG ONE
  • React Native version: 0.51 >=
  • Platform(s) (iOS, Android, or both?): iOS / xcode / OSX
  • Device info (Simulator/Device? OS version? Debug/Release?): IOS - ALL under xcode 10.x
@stale
Copy link

stale bot commented Feb 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Feb 14, 2019
@Pushplaybang
Copy link
Author

update needed.

@stale stale bot removed the 🏚 stale label Feb 14, 2019
@Pushplaybang
Copy link
Author

there seems to be some work around playground happening, are docs being updated as well

#4767 ?

@guyca
Copy link
Collaborator

guyca commented Feb 27, 2019

Hey @Pushplaybang, seems like someone already PR'd a fix to that line. Sorry about the confusion.
Indeed we've reorganised the playground app abit. I think it's friendlier now and more accommodating to PR's and additional e2e tests.

@guyca guyca closed this as completed Feb 27, 2019
@Pushplaybang
Copy link
Author

@guyca awesome, will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants