Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript relevance for topBarOptions #5054

Closed
retyui opened this issue May 1, 2019 · 1 comment
Closed

TypeScript relevance for topBarOptions #5054

retyui opened this issue May 1, 2019 · 1 comment
Assignees

Comments

@retyui
Copy link
Contributor

retyui commented May 1, 2019

Issue Description

TS types have buttonColor

/**
* Change button colors in the top bar
*/
buttonColor?: Color;

But in code we have new leftButtonColor, rightButtonColor

options.rightButtonColor = ColorParser.parse(json, "rightButtonColor");
options.leftButtonColor = ColorParser.parse(json, "leftButtonColor");

As I understand you forgot to update the types (via: #3713).

Does RNN support all three properties?
buttonColor, leftButtonColor and rightButtonColor

Or only two: leftButtonColor and rightButtonColor?

Environment

  • React Native Navigation version: 2.18.0
@retyui
Copy link
Contributor Author

retyui commented May 3, 2019

Based on these changes, I can assume that our need to delete buttonColor and add new :

  • leftButtonColor
  • rightButtonColor
  • leftButtonDisabledColor
  • rightButtonDisabledColor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants