Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Tab should render customizable component (not just icon properties) #7887

Open
1 of 3 tasks
techmonsterco opened this issue Jun 13, 2024 · 1 comment
Open
1 of 3 tasks

Comments

@techmonsterco
Copy link

Describe your idea

Similar to how reactnavigation.org handles their bottom tab.
https://reactnavigation.org/docs/7.x/bottom-tab-navigator/#tabbarbutton

Wix-r-n-n should allow the bottom tab to be any component, not just properties relating to icon.

Motivation

facebook/react-native#23870
and several wix-r-n-n Android specific bugs are related
due to View.getGlobalVisibleRect() returning True in cases.

wix e2e detox known related bug due to Android overlays:
If I create an Absolute Positioned Component and render it at bottom of screen,
Then Android will overdraw. Wix detox e2e tests fail due to saying Android element is on Screen when it is indeed not visible to the user.
Example: A with Many Nested , all will appear 'visible' from test perspective.
detox failure example: await expect(element(by.id(id))).toBeVisible(); (returns always true)
By allowing the Bottom Tab to be customizable, we may avoid this bug.

Even better: Wix, et al. Now have a way to have a 'Component on the bottom of their screen' that can be customizable, and e2e testable from an Android perspective.

Without this: having a 'Component on the bottom of your screen' is NOT testable from an Android e2e perspective (wix/detox)

sidebar: excellent library!

Are you willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time, and I know how to start.
  • Yes, I have the time, but I don't know how to start. I would need guidance.
  • No, I don’t have the time and I’m okay to wait for the community / maintainers to resolve this issue.
@cmdominguez
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants