Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch root while modal is showing, modal leaks #878

Closed
DanielZlotin opened this issue Mar 19, 2017 · 0 comments
Closed

switch root while modal is showing, modal leaks #878

DanielZlotin opened this issue Mar 19, 2017 · 0 comments
Assignees
@DanielZlotin
Milestone
2.x.x Complete Re...

Comments

@DanielZlotin
Copy link
Contributor

DanielZlotin commented Mar 19, 2017 •
edited
Loading

A bug in iOS causes modals to be kept alive by the system when switching the root view under them. I couldn't find a reliable method to test this other than to debug it manually, setting a breakpoint in dealloc of RNNRootViewController, and RNNReactRootView.

Maybe wix/Detox#23 will help.

Currently fixed by manually dismissAllModals when setRoot is called.
@DanielZlotin DanielZlotin added this to the 2.0.0 milestone Mar 19, 2017
@DanielZlotin DanielZlotin self-assigned this Mar 19, 2017
@DanielZlotin DanielZlotin changed the title switch root while modal is showing switch root while modal is showing, modal leaks Mar 20, 2017
@DanielZlotin DanielZlotin mentioned this issue Mar 20, 2017
Closed
DanielZlotin added a commit that referenced this issue Mar 20, 2017
@DanielZlotin
fix for \#878
73927dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielZlotin DanielZlotin

Labels
None yet
Projects
None yet
Milestone
2.x.x Complete Rewrite (full feature ...
Development

No branches or pull requests
1 participant
@DanielZlotin