Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize comments #158

Closed
nippur72 opened this issue Jun 20, 2016 · 0 comments
Closed

Sanitize comments #158

nippur72 opened this issue Jun 20, 2016 · 0 comments

Comments

@nippur72
Copy link
Contributor

The following is valid template code

<div>
   <!-- /* hello */ -->
</div>

but won't compile because the /* */ cause problems due to comment text being embedded as-is in the output:

  2:4  error  Unexpected token *

✖ 1 message (1 error, 0 warnings, 0 infos)

I suggest to sanitize the text against /* and */.

nippur72 added a commit to nippur72/react-templates that referenced this issue Jun 20, 2016
marcusrbrown pushed a commit to marcusrbrown/react-templates that referenced this issue Jun 29, 2016
@idok idok closed this as completed in 46caeea Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant