Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rt-repeat with custom index doesn't work #162

Closed
nippur72 opened this issue Jun 23, 2016 · 0 comments · Fixed by marcusrbrown/react-templates#9
Closed

rt-repeat with custom index doesn't work #162

nippur72 opened this issue Jun 23, 2016 · 0 comments · Fixed by marcusrbrown/react-templates#9

Comments

@nippur72
Copy link
Contributor

the new syntax introduced in #88 doesn't work

<ul>
    <li rt-repeat="item, customIndex in [1,2,3]">{item} is number {customIndex}</li>
</ul>

Uncaught ReferenceError: customIndex is not defined
nippur72 added a commit to nippur72/react-templates that referenced this issue Jun 23, 2016
@nippur72
fix repeat with custom index (wix-incubator#162)
b1b29c2
@nippur72 nippur72 mentioned this issue Jun 23, 2016
Merged
nippur72 added a commit to nippur72/react-templates that referenced this issue Jun 23, 2016
@nippur72
Merge pull request #12 from nippur72/rt-template-child-no-text
6623829 
fix repeat with custom index (wix-incubator#162)
marcusrbrown pushed a commit to marcusrbrown/react-templates that referenced this issue Jun 26, 2016
@nippur72 @marcusrbrown
fix repeat with custom index (wix-incubator#162)
1795ff1
@marcusrbrown marcusrbrown mentioned this issue Jun 26, 2016
Merged
idok pushed a commit that referenced this issue Jul 6, 2016
@nippur72
Fix #138, #139, #134, #144, #145, #147, #157, #158, #161, #162 (#142)
46caeea 
* Single child for rt-template (fixes #138)

* Nested scope functions (fixes #139)

* Forbid nested rt-import (fixes #134)

* Vendor prefixes style keys (#144)

* Renamed test file

* Forbid expressions in style keys (#145)

* fixed rt-import and AMD (#147)

* Updated documentation

* Fixed links in README.md

* Sanitize comments (fix #158)

* Disable comments when es6 (fix#157)

* Added test case for comments

* Simplified TypeScript output

* Test cases for simplified TypeScript output

* Fixed wrong TypeScript output (#161)

* fix repeat with custom index (#162)
@nippur72 nippur72 closed this as completed Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rt-repeat with custom index. marcusrbrown/react-templates
1 participant
@nippur72