Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpack-plugin: support webpack 5 #1064

Closed
AviVahl opened this issue Mar 26, 2020 · 2 comments · Fixed by #1511
Closed

webpack-plugin: support webpack 5 #1064

AviVahl opened this issue Mar 26, 2020 · 2 comments · Fixed by #1511
Labels
future Intended for future roadmap integration Bundler, test-runner and node tech debt Updates, upgrades, stale code and work-arounds
Milestone
v4.0.0

Comments

@AviVahl
Copy link
Collaborator

AviVahl commented Mar 26, 2020

webpack 5 (currently at v5.0.0-beta.14) changed many internal APIs.
Our plugin currently breaks with it (from #1063):

[18:43:26][npm run test] Error: Cannot find module 'webpack/lib/MultiModule'
[18:43:26][npm run test]     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
[18:43:26][npm run test]     at Function.Module._load (internal/modules/cjs/loader.js:507:25)
[18:43:26][npm run test]     at Function._load (/home/builduser/agent00/work/f0c170388923639/promote-seo/promote-seo/node_modules/@sentry/node/dist/integrations/console.js:41:47)
[18:43:26][npm run test]     at Module.require (internal/modules/cjs/loader.js:637:17)
[18:43:26][npm run test]     at require (internal/modules/cjs/helpers.js:22:18)
[18:43:26][npm run test]     at Object.<anonymous> (/home/builduser/agent00/work/f0c170388923639/promote-seo/promote-seo/node_modules/@stylable/webpack-plugin/src/StylableWebpackPlugin.js:23:21)
[18:43:26][npm run test]     at Module._compile (internal/modules/cjs/loader.js:689:30)
[18:43:26][npm run test]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
[18:43:26][npm run test]     at Module.load (internal/modules/cjs/loader.js:599:32)
[18:43:26][npm run test]     at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
[18:43:26][npm run test]     at Function.Module._load (internal/modules/cjs/loader.js:530:3)
[18:43:26][npm run test]     at Function._load (/home/builduser/agent00/work/f0c170388923639/promote-seo/promote-seo/node_modules/@sentry/node/dist/integrations/console.js:41:47)
[18:43:26][npm run test]     at Module.require (internal/modules/cjs/loader.js:637:17)
[18:43:26][npm run test]     at require (internal/modules/cjs/helpers.js:22:18)
[18:43:26][npm run test]     at Object.<anonymous> (/home/builduser/agent00/work/f0c170388923639/promote-seo/promote-seo/node_modules/@stylable/webpack-plugin/src/index.js:1:80)

Ideally, we should support it before the final release.
@AviVahl AviVahl added bug Unexpected behavior or exception future Intended for future roadmap integration Bundler, test-runner and node labels Mar 26, 2020
@AviVahl AviVahl mentioned this issue Mar 26, 2020
Merged
@AviVahl

This comment has been minimized.

Sign in to view
@tomrav tomrav added tech debt Updates, upgrades, stale code and work-arounds and removed bug Unexpected behavior or exception labels May 10, 2020
@AviVahl
Copy link
Collaborator Author

AviVahl commented Sep 13, 2020

webpack/webpack#11406

@AviVahl AviVahl mentioned this issue Nov 22, 2020
Merged
20 tasks
@AviVahl AviVahl added this to the 4.0.0 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future Intended for future roadmap integration Bundler, test-runner and node tech debt Updates, upgrades, stale code and work-arounds
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Support webpack v5 wix/stylable
2 participants
@tomrav @AviVahl