Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board thumbnail is not showing whole board when board has absolute or fixed position #1149

Open
olehrakwix opened this issue Aug 12, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@olehrakwix
Copy link

olehrakwix commented Aug 12, 2024

Steps:

  • start new project from E-Commerce Starter template with Codux
  • install dependencies
  • observe Intro and 5 - Cart boards on home screen:
image
  • open these boards, observe how they should look

Technical details
This issue is caused by change in this PR: #1131
The thing is that previously we were applying board environmentProps settings to a board container (board-canvas), and width and height were set explicitly
Now, board container (board-canvas) has no width and height set. Because mentioned boards root element has position: absolute, this root element is not affecting its parent html element (board-canvas). Thus, board container has size of 0x0:

Because of that, Codux logic to measure board size and fit it into thumbnail is failing.
I think, we should explicitly set width and height for board-canvas element

@olehrakwix olehrakwix added the bug Something isn't working label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants