Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 #635

Open
AviVahl opened this issue Nov 17, 2022 · 0 comments
Open

React 18 #635

AviVahl opened this issue Nov 17, 2022 · 0 comments

Comments

@AviVahl
Copy link
Contributor

AviVahl commented Nov 17, 2022

  • API fits less with React 18's way of rendering. in 17 and below, user cared about holding the container, to re-render and unmount. With 18, the user just needs the root.

  • Synchronous API in 17, but 18 is async rendering.

  • APIs should probably be separated: helper for root/container creation, another for rendering async (promise resolves when mounted), and another for querying elements within a root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant