Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory allocation test verifies incorrect variable #5318

Closed
GregDomjan opened this issue Jun 6, 2016 · 1 comment
Closed

Memory allocation test verifies incorrect variable #5318

GregDomjan opened this issue Jun 6, 2016 · 1 comment
Assignees
Milestone

Comments

@GregDomjan
Copy link

  • Which version of WiX are you building with?
    3.7/3.9.2/3.10.2
  • Describe the problem and the steps to reproduce it.

Reading code to identify an issue with a patch bundle using burn.
Noticed ExitOnNull testing same variable rgPatchInfo looks like it should be verifying rgPatchInfoToPackage on second usage.
https://github.com/wixtoolset/wix3/blob/wix3103/src/burn/engine/package.cpp#L255-256

        pPackages->rgPatchInfo = static_cast<MSIPATCHSEQUENCEINFOW*>(MemAlloc(sizeof(MSIPATCHSEQUENCEINFOW) * cMspPackages, TRUE));
        ExitOnNull(pPackages->rgPatchInfo, hr, E_OUTOFMEMORY, "Failed to allocate memory for MSP patch sequence information.");

        pPackages->rgPatchInfoToPackage = static_cast<BURN_PACKAGE**>(MemAlloc(sizeof(BURN_PACKAGE*) * cMspPackages, TRUE));
        ExitOnNull(pPackages->rgPatchInfo, hr, E_OUTOFMEMORY, "Failed to allocate memory for patch sequence information to package lookup.");
@robmen
Copy link
Member

robmen commented Feb 12, 2017

Fixed

@robmen robmen closed this as completed Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants