Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

Ejecting hardcodes your absolute project path in package.json. #379

Closed
macbem opened this issue Aug 17, 2018 · 1 comment
Closed

Ejecting hardcodes your absolute project path in package.json. #379

macbem opened this issue Aug 17, 2018 · 1 comment

Comments

@macbem
Copy link

macbem commented Aug 17, 2018

In order to reproduce, eject and open package.json :)

Look for the jest.globals['ts-jest'].tsConfigFile key - it should be a relative path, like ./tsconfig.test.json. Instead, it puts an absolute path there, like /Users/user/coding/test-proj/tsconfig.test.json.

This is fine for small projects that you won't share with anyone, but as soon as other people have to work on that project or you want to set up a CI/CD process that runs your tests, you'll get errors related to that path not existing on other people's machines.

So, IMO this is pretty short-sighted. What do you think about it?

@r3nya
Copy link
Contributor

r3nya commented Oct 1, 2018

Hey @macbem!

Faced with this issue as well.
Will be fix in #409 (I hope). :)

Thanks!

@macbem macbem closed this as completed Dec 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants