Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing action_helper in PyPI tarball #644

Closed
frenzymadness opened this issue Aug 9, 2022 · 4 comments · Fixed by #645
Closed

Missing action_helper in PyPI tarball #644

frenzymadness opened this issue Aug 9, 2022 · 4 comments · Fixed by #645

Comments

@frenzymadness
Copy link
Contributor

Current Behavior

In PyPI tarball, there is test_action_helper.py module but the module this one should test (.github/action_helper.py) is not there.

Expected Behavior

I think that the tarball should either contain both files or neither of them.

Steps To Reproduce

  1. Download and unpack the tarball.
  2. Run tests.

Environment

Does not matter

Anything else?

No response

@DiddiLeija
Copy link
Collaborator

I found both files...

I first decompressed the tarball, then looked for both files, and I found them (both .github/action_helper.py and tests/test_action_helper.py).

However, I haven't tried to run the tests yet.

@DiddiLeija
Copy link
Collaborator

Oh no, you're right, the PyPI tarball (from https://pypi.org/project/nox/#files) does not contain the .github section. However, the GitHub tarball does 🤷‍♂️.

@frenzymadness
Copy link
Contributor Author

Yes, github tarball contains everything from the repo. PyPI tarballs contain only what is included by the build system - so the files are either identified or specified in pyproject.toml or manually included in tarball via MANIFEST.in.

To fix this inconsistency, we can either include the action_helper.py into PyPI tarball via MANIFEST.in or use the same file for excluding the test_action_helper.py.

@DiddiLeija
Copy link
Collaborator

To fix this inconsistency, we can either include the action_helper.py into PyPI tarball via MANIFEST.in or use the same file for excluding the test_action_helper.py.

cc @wntrblm/nox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants