Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it make sense to default :retry_log_level to :warning? #369

Closed
jozuas opened this issue Jun 7, 2024 · 1 comment · Fixed by #370
Closed

Would it make sense to default :retry_log_level to :warning? #369

jozuas opened this issue Jun 7, 2024 · 1 comment · Fixed by #370

Comments

@jozuas
Copy link
Contributor

jozuas commented Jun 7, 2024

I'm aware #357, but while that's in the process of consideration, would it make sense to default :retry_log_level to :warning?

In my view, transient networking issues are expected, and with the default retry behaviour recoverable. What should be an error is if the retries eventually failing, not each individual retry step.

@wojtekmach
Copy link
Owner

Good call, a PR would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants