Reloading the document on every prop change

[jsardev]

Before you start - checklist

• I followed instructions in documentation written for my React-PDF version
• I have checked if this bug is not already reported
• I have checked if an issue is not listed in Known issues

Description

<Document /> reloads the document on every prop change when you're passing an object to the file prop.

Steps to reproduce

Pass an object to file prop.

Expected behavior

In the code below, the file check should consider being an object, which in most cases will be everytime something new, as {} !== {}.

react-pdf/src/Document.jsx

Lines 72 to 77 in 2acb1a8

	componentDidUpdate(prevProps) {
	const { file } = this.props;
	if (file !== prevProps.file) {
	this.loadDocument();
	}
	}

Environment

• React-PDF: 4.0.5
• React: 16.8.6

[jsardev]

The workaround is to:

Instead of:
<Document file={{ url: '/name.pdf', withCredentials: true }} />
do:
<Document file="/name.pdf" options={{ withCredentials: true }} />

[wojtekmaj]

Duplicate of #308

[jsardev]

@wojtekmaj Oeps, sorry, I missed it 😢

[pavan-singh-iphtech]

The workaround is to:

Instead of: <Document file={{ url: '/name.pdf', withCredentials: true }} /> do: <Document file="/name.pdf" options={{ withCredentials: true }} />

not work in case of re ordering pdf