Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Remove Activity Panel #1346

Closed
justinshreve opened this issue Jan 17, 2019 · 7 comments
Closed

Remove Activity Panel #1346

justinshreve opened this issue Jan 17, 2019 · 7 comments
Labels
focus: activity panel Issues about activity/task panels on the home screen. type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@justinshreve
Copy link
Collaborator

Blocked by #1345.

Prior to 3.6, we need to remove the activity panel from our current build. Using feature flags, we can keep the code around. This issue is considered finished when we can release a bundled .zip without the activity panel, breadcrumbs, and "embed" entry point code.

@justinshreve justinshreve added type: task The issue is an internally driven task (e.g. from another A8c team). focus: activity panel Issues about activity/task panels on the home screen. On Merge to WC Core labels Jan 17, 2019
@timmyc
Copy link
Contributor

timmyc commented Jan 18, 2019

Confirming that by Activity Panel we also are including the header area too?

image

Other question on this one, without the activity panels, I'm assuming we are no longer hiding admin alerts too.

/cc @LevinMedia

@justinshreve
Copy link
Collaborator Author

Confirming that by Activity Panel we also are including the header area too?

Yes - the breadcrumbs should be removed too. We can't accurately do them without smarter page handling: p90Yrv-U3-p2.

Other question on this one, without the activity panels, I'm assuming we are no longer hiding admin alerts too.

Good question.

We could do a simple hide on the dashboard and reports (using CSS) like we do in the eCommerce plan, since users will still see notices in other sections of WooCommerce.

Or we could move the current logic out and have a different button for showing/hiding them? I'd hate to clutter up our reports and dashboard with a bunch of notices out of the box.

@timmyc
Copy link
Contributor

timmyc commented Jan 18, 2019

Or we could move the current logic out and have a different button for showing/hiding them? I'd hate to clutter up our reports and dashboard with a bunch of notices out of the box.

+1 I'd still love to keep them hidden on the reports, I think @josemarques was concerned about doing that though without a way for them to be viewed.

@josemarques
Copy link

I'm a bit divided on this one. It would be nice to deliver the analytics section without the notices jank, but hiding notices and not providing an alternative way to access them on those screens might be dangerous.

I think we should keep the notices until we can properly handle them with the activity panel. @LevinMedia what do you think?

@justinshreve
Copy link
Collaborator Author

but hiding notices and not providing an alternative way to access them on those screens might be dangerous.

What about just an indicator/button for WP notices like I mentioned above? Something like this (mocked up with Inspector -- the button/link can be something else):

screen shot 2019-01-21 at 10 52 19 am

screen shot 2019-01-21 at 11 48 56 am

@josemarques
Copy link

@timmyc I believe it's no longer necessary to remove the Activity Panel due to re-planning of release cycles and keeping this as feature plugin?

@timmyc
Copy link
Contributor

timmyc commented Jan 22, 2019

That is correct @josemarques I'll close this out.

@timmyc timmyc closed this as completed Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: activity panel Issues about activity/task panels on the home screen. type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

No branches or pull requests

3 participants