Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets are lowercased in list #3096

Closed
5 tasks done
CodeDoctorDE opened this issue Dec 31, 2023 · 3 comments · Fixed by #3375
Closed
5 tasks done

Secrets are lowercased in list #3096

CodeDoctorDE opened this issue Dec 31, 2023 · 3 comments · Fixed by #3375
Labels
enhancement improve existing features ui frontend related ux user experience

Comments

@CodeDoctorDE
Copy link

Component

web-ui

Describe the bug

After creating the secret in UPPERCASE, the list shows it in lowercase

System Info

2.1.1

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.
@CodeDoctorDE CodeDoctorDE added the bug Something isn't working label Dec 31, 2023
@6543 6543 added ui frontend related ux user experience labels Dec 31, 2023
@6543
Copy link
Member

6543 commented Dec 31, 2023

note: all secret names are handled upperscase (to match, as env var, ...)

@anbraten
Copy link
Member

anbraten commented Jan 1, 2024

We change the secrets to lower case on save and convert all secrets in the config to lowercase as well. So this is not a bug. Do you want to change it to be always uppercase?

@anbraten anbraten added enhancement improve existing features and removed bug Something isn't working labels Jan 1, 2024
@CodeDoctorDE
Copy link
Author

Yeah, this would be a good idea.
I spent plenty of hours figuring out why my bash step was failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features ui frontend related ux user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants