Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the point of the "terminated" property? #7

Closed
superbull opened this issue Mar 2, 2016 · 1 comment
Closed

What's the point of the "terminated" property? #7

superbull opened this issue Mar 2, 2016 · 1 comment

Comments

@superbull
Copy link
Contributor

In the current code, it seems the terminated property of the class Harmony is useless.

Is there any use case for this?

@kocsismate
Copy link
Member

Yes, you are right, there is no need for it anymore, so I've just removed it in my last commit (442edf4)! Originally, It helped to ensure that final middlewares are only run once (but I became unsure if it was really needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants