New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OffsetPagination bug, offset and limit mixup #25

Closed

dragontoe opened this issue Jun 13, 2016 · 1 comment

dragontoe commented Jun 13, 2016

Hi,

It looks like $defaultOffset and $defaultLimit is sent in the wrong order here

...($this->getPagination(), $defaultLimit, $defaultOffset);
should be
...($this->getPagination(), $defaultOffset, $defaultLimit);

Member

kocsismate commented Jun 13, 2016

Hey,

You are right, thank your very much for the effort! I've just fixed it in my recent commit: 102eba3

I am currently releasing Yin 0.10.7. :)

kocsismate closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment