Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add command line args for customing colors #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kyoto7250
Copy link

@kyoto7250 kyoto7250 commented Jul 18, 2022

close #9

We can specific colors on the command line by this PR.

If you have more better idea, please let me know :)

# usage
gpustat --custom-colors CName=white --custom-colors CUser=white

Thank you for your awesome application!

@kyoto7250 kyoto7250 marked this pull request as ready for review July 18, 2022 15:36
@wookayin
Copy link
Owner

Thanks, this looks like a good option to add. I have two thoughts:

First, it would be great if one can list multiple color entries in a single flag (with the comma separator), just like fzf supports:

gpustat --custom-colors CName=white
gpustat --custom-colors CName=white,CUser=white,CFoo=bar

Second, the color keys such as CName, CUser were chosen for internal use of string formatting, so I would prefer some universal name that is more consistent with self.entry or json output, e.g. name, memory.used, memory.total. Let me think more what'd be the best.

@kyoto7250
Copy link
Author

kyoto7250 commented Jul 19, 2022

Thank you for your review.

Let me think more what'd be the best.

Okay, let me know if you come up with a good idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Displaying username on dark terminals
2 participants